Skip to content

Commit 273920b

Browse files
committed
Fix NPE in takeBackup if the vm template is deleted.
1 parent 77e9125 commit 273920b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,9 @@ public Map<String, String> getBackupDetailsFromVM(VirtualMachine vm) {
379379
ServiceOffering serviceOffering = serviceOfferingDao.findById(vm.getServiceOfferingId());
380380
details.put(ApiConstants.SERVICE_OFFERING_ID, serviceOffering.getUuid());
381381
VirtualMachineTemplate template = vmTemplateDao.findById(vm.getTemplateId());
382-
details.put(ApiConstants.TEMPLATE_ID, template.getUuid());
382+
if (template != null) {
383+
details.put(ApiConstants.TEMPLATE_ID, template.getUuid());
384+
}
383385

384386
List<VMInstanceDetailVO> vmDetails = vmInstanceDetailsDao.listDetails(vm.getId());
385387
HashMap<String, String> settings = new HashMap<>();

0 commit comments

Comments
 (0)