Skip to content

Commit 2771586

Browse files
committed
Merge release branch 4.19 to 4.20
* 4.19: plugin/shutdown: use mgmt server uuid in the shutdown response (#10717)
2 parents 199170b + 29e58e9 commit 2771586

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

plugins/shutdown/src/main/java/org/apache/cloudstack/api/response/ReadyForShutdownResponse.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ public class ReadyForShutdownResponse extends BaseResponse {
3838

3939
@SerializedName(ApiConstants.MANAGEMENT_SERVER_ID)
4040
@Param(description = "The id of the management server")
41-
private Long msId;
41+
private String msUuid;
4242

43-
public ReadyForShutdownResponse(Long msId, Boolean shutdownTriggered, Boolean readyForShutdown, long pendingJobsCount) {
44-
this.msId = msId;
43+
public ReadyForShutdownResponse(String msUuid, Boolean shutdownTriggered, Boolean readyForShutdown, long pendingJobsCount) {
44+
this.msUuid = msUuid;
4545
this.shutdownTriggered = shutdownTriggered;
4646
this.readyForShutdown = readyForShutdown;
4747
this.pendingJobsCount = pendingJobsCount;
@@ -70,12 +70,4 @@ public Long getPendingJobsCount() {
7070
public void setPendingJobsCount(Long pendingJobsCount) {
7171
this.pendingJobsCount = pendingJobsCount;
7272
}
73-
74-
public Long getMsId() {
75-
return msId;
76-
}
77-
78-
public void setMsId(Long msId) {
79-
this.msId = msId;
80-
}
8173
}

plugins/shutdown/src/main/java/org/apache/cloudstack/shutdown/ShutdownManagerImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ public void cancelShutdown() {
134134
public ReadyForShutdownResponse readyForShutdown(Long managementserverid) {
135135
Long[] msIds = null;
136136
boolean shutdownTriggeredAnywhere = false;
137+
String msUuid = null;
137138
State[] shutdownTriggeredStates = {State.ShuttingDown, State.PreparingToShutDown, State.ReadyToShutDown};
138139
if (managementserverid == null) {
139140
List<ManagementServerHostVO> msHosts = msHostDao.listBy(shutdownTriggeredStates);
@@ -146,11 +147,12 @@ public ReadyForShutdownResponse readyForShutdown(Long managementserverid) {
146147
}
147148
} else {
148149
ManagementServerHostVO msHost = msHostDao.findById(managementserverid);
150+
msUuid = msHost.getUuid();
149151
msIds = new Long[]{msHost.getMsid()};
150152
shutdownTriggeredAnywhere = Arrays.asList(shutdownTriggeredStates).contains(msHost.getState());
151153
}
152154
long pendingJobCount = countPendingJobs(msIds);
153-
return new ReadyForShutdownResponse(managementserverid, shutdownTriggeredAnywhere, pendingJobCount == 0, pendingJobCount);
155+
return new ReadyForShutdownResponse(msUuid, shutdownTriggeredAnywhere, pendingJobCount == 0, pendingJobCount);
154156
}
155157

156158
@Override

0 commit comments

Comments
 (0)