Address Henrique review

Author: BryanMLima

engine/schema/src/main/java/org/apache/cloudstack/gui/theme/GuiThemeVO.java

@@ -47,10 +47,10 @@ public class GuiThemeVO implements GuiTheme {
     @Column(name = "description", length = 4096)
     private String description;
 
-    @Column(name = "css", nullable = false, length = 65535)
+    @Column(name = "css", length = 65535)
     private String css;
 
-    @Column(name = "json_configuration", nullable = false, length = 65535)
+    @Column(name = "json_configuration", length = 65535)
     private String jsonConfiguration;
 
     @Column(name = "is_public")

engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql

@@ -50,8 +50,8 @@ CREATE TABLE IF NOT EXISTS `cloud`.`gui_themes` (
 CREATE TABLE IF NOT EXISTS `cloud`.`gui_themes_details` (
     `id` bigint(20) unsigned NOT NULL auto_increment,
     `gui_theme_id` bigint(20) unsigned NOT NULL COMMENT 'Foreign key referencing the GUI theme on `gui_themes` table.',
-    `type` varchar(100) DEFAULT NULL COMMENT 'The type of GUI theme details. Valid options are: `account`, `domain` and `commonName`',
-    `value` text COMMENT 'The value of the `type` details. Can be an UUID (account or domain) or internet common name.',
+    `type` varchar(100) DEFAULT NOT NULL COMMENT 'The type of GUI theme details. Valid options are: `account`, `domain` and `commonName`',
+    `value` text NOT NULL COMMENT 'The value of the `type` details. Can be an UUID (account or domain) or internet common name.',
     PRIMARY KEY (`id`),
     CONSTRAINT `fk_gui_themes_details__gui_theme_id` FOREIGN KEY (`gui_theme_id`) REFERENCES `gui_themes`(`id`)
 );

ui/public/css/apache-theme.css

@@ -157,7 +157,7 @@ html{
   background-color:var(--main-secondary-claro) !important;
 }
 
-/* BARRA LATERAL */
+/* SIDE BAR */
 
 .vm-info-card .ant-card-body .ant-card-bordered{
   border-top:2px solid var(--main-primary-escuro) !important;
@@ -177,7 +177,7 @@ html{
   font-weight:900;
 }
 
-/* TELA USER LOGIN */
+/* USER LOGIN SCREEN */
 
 .ant-tabs-tab,
 .user-layout{
@@ -272,7 +272,7 @@ html{
   background-color:var(--main-primary-claro)  !important;
 }
 
-/* PAGINACAO */
+/* PAGINATION */
 .ant-pagination .ant-pagination-item.ant-pagination-item-active{
   background-color:var(--main-primary-escuro) !important;
   border-color:#fff;
@@ -739,7 +739,7 @@ button.ant-btn:not(.ant-btn-icon-only):hover{
   color:#fff !important;
 }
 
-/* GRAFICOS  */
+/* CHARTS  */
 
 .ant-progress .ant-progress-status-normal path{
   stroke:var(--main-exception) !important;
@@ -769,7 +769,7 @@ button.ant-btn:not(.ant-btn-icon-only):hover{
   font-weight: bold
 }
 
-/* lISTAS TABELADAS  */
+/* LIST TABLES  */
 .ant-list .ant-list-item{
   border-left:5px solid transparent !important;
   padding-left:10px;
@@ -798,7 +798,7 @@ button.ant-btn:not(.ant-btn-icon-only):hover{
   background-color:var(--main-secondary-escuro) !important;
 }
 
-/* OUTROS  */
+/* OTHERS  */
 
 .ant-tree li .ant-tree-node-content-wrapper.ant-tree-node-selected{
   background-color:var(--main-primary-claro)
@@ -875,7 +875,7 @@ button.ant-btn:not(.ant-btn-icon-only):hover{
   transform: scale(1.3);
 }
 
-/* CADASTROS FORMS E ADDS */
+/* REGISTRATIONS FORMS AND ADDS */
 .ant-steps-item-tail{
   margin-top:15px;
 }

ui/public/css/dark-theme.css

@@ -100,7 +100,7 @@
   color:#000 !important;
 }
 
-/* USER MMENU DARK */
+/* USER MENU DARK */
 *{
   font-family: 'Poppins' , Courier !important;
 }
@@ -156,7 +156,7 @@ html{
   background-color:var(--main-secondary-claro) !important;
 }
 
-/* BARRA LATERAL */
+/* SIDE BAR */
 .ant-card {
   background-color: var(--main-linear-cora) !important;
 }
@@ -179,7 +179,7 @@ html{
   font-weight:900;
 }
 
-/* TELA USER LOGIN */
+/* USER LOGIN SCREEN */
 
 .ant-tabs-tab,
 .user-layout{
@@ -284,7 +284,7 @@ html{
   background-color:var(--main-primary-claro)  !important;
 }
 
-/* PAGINACAO */
+/* PAGINATION */
 .ant-pagination .ant-pagination-item.ant-pagination-item-active{
   background-color:var(--main-primary-escuro) !important;
   border-color:#fff;
@@ -767,7 +767,7 @@ button.ant-btn:hover{
   color:#fff !important;
 }
 
-/* GRAFICOS  */
+/* CHARTS  */
 
 .ant-progress .ant-progress-status-normal path{
   stroke:var(--main-exception) !important;
@@ -797,7 +797,7 @@ button.ant-btn:hover{
   font-weight: bold
 }
 
-/* lISTAS TABELADAS  */
+/* LIST TABLES  */
 .ant-list .ant-list-item{
   border-left:5px solid transparent !important;
   padding-left:10px;
@@ -832,7 +832,7 @@ button.ant-btn:hover{
   background-color:var(--main-secondary-escuro) !important;
 }
 
-/* OUTROS  */
+/* OTHERS  */
 
 .ant-tree li .ant-tree-node-content-wrapper.ant-tree-node-selected{
   background-color:var(--main-primary-claro)
@@ -909,7 +909,7 @@ button.ant-btn:hover{
   transform: scale(1.3);
 }
 
-/* CADASTROS FORMS E ADDS */
+/* REGISTRATIONS FORMS AND ADDS */
 .ant-steps-item-tail{
   margin-top:15px;
 }
@@ -1535,7 +1535,7 @@ button.ant-btn.ant-btn-dangerous:not(.ant-btn-icon-only)
 }
 
 
-/* SOMENTE DARK */
+/* DARK ONLY */
 .ant-modal-body .ant-table-bordered .ant-table-body .ant-table-row-cell-break-word .ant-btn-circle.ant-btn-dangerous span{
   background-color: transparent;
   margin-right:5px !important;