trying new approach

Author: bernardodemarco

api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java

@@ -48,7 +48,7 @@ public class UpdateCfgCmd extends BaseCmd {
     @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = true, description = "the name of the configuration")
     private String cfgName;
 
-    @Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, required = true, description = "the value of the configuration", length = 4096)
+    @Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, description = "the value of the configuration", length = 4096)
     private String value;
 
     @Parameter(name = ApiConstants.ZONE_ID,

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

@@ -1030,6 +1030,10 @@ public Configuration updateConfiguration(final UpdateCfgCmd cmd) throws InvalidP
             category = config.getCategory();
         }
 
+        if (value == null) {
+            throw new InvalidParameterValueException(String.format("A value for the [%s] configuration must be informed.", name));
+        }
+
         validateIpAddressRelatedConfigValues(name, value);
         validateConflictingConfigValue(name, value);
 

test/integration/smoke/test_deploy_vm_extra_config_data.py

@@ -125,9 +125,6 @@ def setUp(self):
 
     # Ste Global Config value
     def add_global_config(self, name, value):
-        if len(value) == 0:
-            value = ' '
-
         self.apiclient = self.testClient.getApiClient()
         self.hypervisor = self.testClient.getHypervisorInfo()
         self.dbclient = self.testClient.getDbConnection()

test/integration/smoke/test_global_settings.py

@@ -79,7 +79,7 @@ def tearDown(self):
 
         updateConfigurationCmd = updateConfiguration.updateConfigurationCmd()
         updateConfigurationCmd.name = "commands.timeout"
-        updateConfigurationCmd.value = " "
+        updateConfigurationCmd.value = ""
         self.apiClient.updateConfiguration(updateConfigurationCmd)
 
 class TestListConfigurations(cloudstackTestCase):

test/integration/smoke/test_vm_strict_host_tags.py

@@ -97,9 +97,6 @@ def expunge_vm(self, vm):
 
     @classmethod
     def updateConfiguration(self, name, value):
-        if len(value) == 0:
-            value = ' '
-
         cmd = updateConfiguration.updateConfigurationCmd()
         cmd.name = name
         cmd.value = value
@@ -268,9 +265,6 @@ def expunge_vm(self, vm):
 
     @classmethod
     def updateConfiguration(self, name, value):
-        if len(value) == 0:
-            value = ' '
-
         cmd = updateConfiguration.updateConfigurationCmd()
         cmd.name = name
         cmd.value = value
@@ -391,9 +385,6 @@ def expunge_vm(self, vm):
 
     @classmethod
     def updateConfiguration(self, name, value):
-        if len(value) == 0:
-            value = ' '
-
         cmd = updateConfiguration.updateConfigurationCmd()
         cmd.name = name
         cmd.value = value
@@ -518,9 +509,6 @@ def expunge_vm(self, vm):
 
     @classmethod
     def updateConfiguration(self, name, value):
-        if len(value) == 0:
-            value = ' '
-
         cmd = updateConfiguration.updateConfigurationCmd()
         cmd.name = name
         cmd.value = value

ui/src/views/setting/ConfigurationValue.vue

@@ -275,14 +275,6 @@ export default {
       if (configrecord.type === 'WhitespaceSeparatedListWithOptions') {
         newValue = newValue.join(' ')
       }
-
-      // The updateConfiguration API expects a blank string to clean up the configuration value
-      if (
-        (['CSV', 'Order', 'WhitespaceSeparatedListWithOptions', 'String'].includes(configrecord.type) && newValue.length === 0)
-      ) {
-        newValue = ' '
-      }
-
       const params = {
         [this.scopeKey]: this.$route.params?.id,
         name: configrecord.name,
@@ -370,17 +362,6 @@ export default {
         }
         return 0
       }
-
-      if (configrecord.value?.trim().length === 0) {
-        if (['CSV', 'Order', 'WhitespaceSeparatedListWithOptions'].includes(configrecord.type)) {
-          return []
-        }
-
-        if (configrecord.type === 'String') {
-          return ''
-        }
-      }
-
       if (['Order', 'CSV'].includes(configrecord.type)) {
         if (configrecord.value && configrecord.value.length > 0) {
           return String(configrecord.value).split(',')