Reconcile: fix java.lang.ArrayIndexOutOfBoundsException

weizhouapache · weizhouapache · commit 3359ec86a967 · 2025-03-07T10:12:00.000+01:00
diff --git a/server/src/main/java/org/apache/cloudstack/command/ReconcileCommandServiceImpl.java b/server/src/main/java/org/apache/cloudstack/command/ReconcileCommandServiceImpl.java
@@ -678,7 +678,7 @@ public void processAnswers(long requestSeq, Command[] commands, Answer[] answers
         if (commands.length != answers.length) {
             logger.error(String.format("Incorrect number of commands (%s) and answers (%s)", commands.length, answers.length));
         }
-        for (int i = 0; i < commands.length; i++) {
+        for (int i = 0; i < answers.length; i++) {
             Command command = commands[i];
             Answer answer = answers[i];
             if (command.isReconcile() && answer.getResult()) {

Original file line number	Diff line number	Diff line change
`@@ -678,7 +678,7 @@ public void processAnswers(long requestSeq, Command[] commands, Answer[] answers`
`678`	`678`	`if (commands.length != answers.length) {`
`679`	`679`	`logger.error(String.format("Incorrect number of commands (%s) and answers (%s)", commands.length, answers.length));`
`680`	`680`	`}`
`681`		`- for (int i = 0; i < commands.length; i++) {`
	`681`	`+ for (int i = 0; i < answers.length; i++) {`
`682`	`682`	`Command command = commands[i];`
`683`	`683`	`Answer answer = answers[i];`
`684`	`684`	`if (command.isReconcile() && answer.getResult()) {`