backwards compatible response

Author: Daan Hoogland

api/src/main/java/org/apache/cloudstack/api/response/RouterHealthCheckResultResponse.java

@@ -36,8 +36,12 @@ public class RouterHealthCheckResultResponse extends BaseResponse {
     private String checkType;
 
     @SerializedName(ApiConstants.SUCCESS)
-    @Param(description = "result of the health check")
-    private RouterHealthStatus result;
+    @Param(description = "result of the health check if available")
+    private boolean result;
+
+    @SerializedName(ApiConstants.STATUS)
+    @Param(description = "the result of the health check in enum form: {SUCCESS, FAILURE, WARNING, UNKNOWN}")
+    private RouterHealthStatus state;
 
     @SerializedName(ApiConstants.LAST_UPDATED)
     @Param(description = "the date this VPC was created")
@@ -55,10 +59,14 @@ public String getCheckType() {
         return checkType;
     }
 
-    public RouterHealthStatus getResult() {
+    public Boolean getResult() {
         return result;
     }
 
+    public RouterHealthStatus getState() {
+        return state;
+    }
+
     public Date getLastUpdated() {
         return lastUpdated;
     }
@@ -75,10 +83,14 @@ public void setCheckType(String checkType) {
         this.checkType = checkType;
     }
 
-    public void setResult(RouterHealthStatus result) {
+    public void setResult(Boolean result) {
         this.result = result;
     }
 
+    public void setState(RouterHealthStatus state) {
+        this.state = state;
+    }
+
     public void setLastUpdated(Date lastUpdated) {
         this.lastUpdated = lastUpdated;
     }

server/src/main/java/com/cloud/api/ApiResponseHelper.java

@@ -5100,7 +5100,17 @@ public List<RouterHealthCheckResultResponse> createHealthCheckResponse(VirtualMa
             healthCheckResponse.setObjectName("routerhealthchecks");
             healthCheckResponse.setCheckName(hcResult.getCheckName());
             healthCheckResponse.setCheckType(hcResult.getCheckType());
-            healthCheckResponse.setResult(hcResult.getCheckResult());
+            switch (hcResult.getCheckResult()) {
+                case SUCCESS:
+                    healthCheckResponse.setResult(true);
+                    break;
+                case FAILED:
+                    healthCheckResponse.setResult(false);
+                    break;
+                default:
+                    // no result if not definite
+            }
+            healthCheckResponse.setState(hcResult.getCheckResult());
             healthCheckResponse.setLastUpdated(hcResult.getLastUpdateTime());
             healthCheckResponse.setDetails(hcResult.getParsedCheckDetails());
             responses.add(healthCheckResponse);

ui/src/views/infra/routers/RouterHealthCheck.vue

@@ -35,7 +35,7 @@
         size="large">
         <template #bodyCell="{ column, record }">
           <template v-if="column.key === 'status'">
-            <status class="status" :text="record.success" displayText />
+            <status class="status" :text="record.status" displayText />
           </template>
         </template>
       </a-table>
@@ -113,7 +113,7 @@ export default {
         },
         {
           key: 'status',
-          dataIndex: 'success',
+          dataIndex: 'status',
           title: this.$t('label.router.health.check.success')
         },
         {