enhance access control validation

Author: bernardodemarco

api/src/main/java/org/apache/cloudstack/api/command/user/consoleproxy/ListConsoleSessionsCmd.java

@@ -50,6 +50,7 @@ public class ListConsoleSessionsCmd extends BaseListCmd {
     @Inject
     private ConsoleAccessManager consoleAccessManager;
 
+    @ACL
     @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = ConsoleSessionResponse.class, description = "The ID of the console session.")
     private Long id;
 

server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java

@@ -268,7 +268,7 @@ protected long getBaseDomainIdToListConsoleSessions(Long domainId) {
 
     @Override
     public ConsoleSession listConsoleSessionById(long id) {
-        return consoleSessionDao.findById(id);
+        return consoleSessionDao.findByIdIncludingRemoved(id);
     }
 
     @Override

server/src/test/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImplTest.java

@@ -309,6 +309,6 @@ public void getBaseDomainIdToListConsoleSessionsTestPerformAccessValidationWhenD
     @Test
     public void listConsoleSessionByIdTestShouldCallDbLayer() {
         consoleAccessManager.listConsoleSessionById(1L);
-        Mockito.verify(consoleSessionDaoMock).findById(1L);
+        Mockito.verify(consoleSessionDaoMock).findByIdIncludingRemoved(1L);
     }
 }