Skip to content

Commit 5a7d4a8

Browse files
committed
fix no bean found
Signed-off-by: Abhishek Kumar <[email protected]>
1 parent f84e7d9 commit 5a7d4a8

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

server/src/main/java/com/cloud/user/AccountManagerImpl.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
import org.apache.commons.lang3.StringUtils;
8686
import org.apache.log4j.Logger;
8787
import org.jetbrains.annotations.NotNull;
88+
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
8889

8990
import com.cloud.api.ApiDBUtils;
9091
import com.cloud.api.auth.SetupUserTwoFactorAuthenticationCmd;
@@ -172,6 +173,7 @@
172173
import com.cloud.utils.NumbersUtil;
173174
import com.cloud.utils.Pair;
174175
import com.cloud.utils.Ternary;
176+
import com.cloud.utils.component.ComponentContext;
175177
import com.cloud.utils.component.Manager;
176178
import com.cloud.utils.component.ManagerBase;
177179
import com.cloud.utils.component.PluggableService;
@@ -302,8 +304,6 @@ public class AccountManagerImpl extends ManagerBase implements AccountManager, M
302304
private UserDataDao userDataDao;
303305
@Inject
304306
private NetworkPermissionDao networkPermissionDao;
305-
@Inject
306-
KubernetesServiceHelper kubernetesServiceHelper;
307307

308308
private List<QuerySelector> _querySelectors;
309309

@@ -851,6 +851,16 @@ public boolean deleteAccount(AccountVO account, long callerUserId, Account calle
851851
return cleanupAccount(account, callerUserId, caller);
852852
}
853853

854+
protected void cleanupPluginsResourcesIfNeeded(Account account) {
855+
try {
856+
KubernetesServiceHelper kubernetesServiceHelper =
857+
ComponentContext.getDelegateComponentOfType(KubernetesServiceHelper.class);
858+
kubernetesServiceHelper.cleanupForAccount(account);
859+
} catch (NoSuchBeanDefinitionException ignored) {
860+
s_logger.debug("No KubernetesServiceHelper bean found");
861+
}
862+
}
863+
854864
protected boolean cleanupAccount(AccountVO account, long callerUserId, Account caller) {
855865
long accountId = account.getId();
856866
boolean accountCleanupNeeded = false;
@@ -932,7 +942,7 @@ protected boolean cleanupAccount(AccountVO account, long callerUserId, Account c
932942
}
933943
}
934944

935-
kubernetesServiceHelper.cleanupForAccount(account);
945+
cleanupPluginsResourcesIfNeeded(account);
936946

937947
// Destroy the account's VMs
938948
List<UserVmVO> vms = _userVmDao.listByAccountId(accountId);

server/src/test/java/com/cloud/user/AccountManagetImplTestBase.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import com.cloud.dc.dao.DedicatedResourceDao;
2525
import com.cloud.domain.dao.DomainDao;
2626
import com.cloud.event.dao.UsageEventDao;
27-
import com.cloud.kubernetes.cluster.KubernetesServiceHelper;
2827
import com.cloud.network.as.AutoScaleManager;
2928
import com.cloud.network.dao.AccountGuestVlanMapDao;
3029
import com.cloud.network.dao.IPAddressDao;
@@ -199,8 +198,6 @@ public class AccountManagetImplTestBase {
199198
UserDataDao userDataDao;
200199
@Mock
201200
NetworkPermissionDao networkPermissionDaoMock;
202-
@Mock
203-
KubernetesServiceHelper kubernetesServiceHelper;
204201

205202
@Spy
206203
@InjectMocks

0 commit comments

Comments
 (0)