add missing return

Pearl1594 · Pearl1594 · commit 63f659c10847 · 2025-03-21T08:15:33.000-04:00
diff --git a/server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java b/server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
@@ -204,6 +204,7 @@ public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan pla
 
         if (clusterHosts.isEmpty()) {
             logger.warn("No suitable host found for VM [{}] with tags {} in {}.", vmProfile, hostTagOnOffering, paramAsStringToLog);
+            return null;
         }
         // add all hosts that we are not considering to the avoid list
         List<HostVO> allhostsInCluster = _hostDao.listAllUpAndEnabledNonHAHosts(type, clusterId, podId, dcId, null);

Original file line number	Diff line number	Diff line change
`@@ -204,6 +204,7 @@ public List<Host> allocateTo(VirtualMachineProfile vmProfile, DeploymentPlan pla`
`204`	`204`
`205`	`205`	`if (clusterHosts.isEmpty()) {`
`206`	`206`	`logger.warn("No suitable host found for VM [{}] with tags {} in {}.", vmProfile, hostTagOnOffering, paramAsStringToLog);`
	`207`	`+ return null;`
`207`	`208`	`}`
`208`	`209`	`// add all hosts that we are not considering to the avoid list`
`209`	`210`	`List<HostVO> allhostsInCluster = _hostDao.listAllUpAndEnabledNonHAHosts(type, clusterId, podId, dcId, null);`