Skip to content

Commit 65a0e36

Browse files
committed
Address comments
1 parent c84082e commit 65a0e36

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1321,7 +1321,7 @@ public void orchestrateStart(final String vmUuid, final Map<VirtualMachineProfil
13211321

13221322
if (!changeState(vm, Event.OperationSucceeded, destHostId, work, Step.Done)) {
13231323
logger.error("Unable to transition to a new state. VM uuid: {}, VM oldstate: {}, Event: {}", vm, vm.getState(), Event.OperationSucceeded);
1324-
throw new ConcurrentOperationException("Failed to deploy VM"+ vm);
1324+
throw new ConcurrentOperationException(String.format("Failed to deploy VM %s", vm));
13251325
}
13261326

13271327
final GPUDeviceTO gpuDevice = startAnswer.getVirtualMachine().getGpuDevice();
@@ -2125,7 +2125,7 @@ private void advanceStop(final VMInstanceVO vm, final boolean cleanUpEvenIfUnabl
21252125
HostVO host = _hostDao.findById(hostId);
21262126
if (!cleanUpEvenIfUnableToStop && vm.getState() == State.Running && host.getResourceState() == ResourceState.PrepareForMaintenance) {
21272127
logger.debug("Host is in PrepareForMaintenance state - Stop VM operation on the VM: {} is not allowed", vm);
2128-
throw new CloudRuntimeException(String.format("Stop VM operation on the VM id%s is not allowed as host is preparing for maintenance mode", vm));
2128+
throw new CloudRuntimeException(String.format("Stop VM operation on the VM %s is not allowed as host is preparing for maintenance mode", vm));
21292129
}
21302130
}
21312131

plugins/storage/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/manager/ScaleIOSDCManagerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ public String prepareSDC(Host host, DataStore dataStore) {
203203
}
204204

205205
private String prepareSDCOnHost(Host host, DataStore dataStore, String systemId) {
206-
logger.debug("Preparing SDC on the host {}", host.toString());
206+
logger.debug("Preparing SDC on the host {}", host);
207207
Map<String,String> details = new HashMap<>();
208208
details.put(ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID, systemId);
209209
PrepareStorageClientCommand cmd = new PrepareStorageClientCommand(((PrimaryDataStore) dataStore).getPoolType(), dataStore.getUuid(), details);

0 commit comments

Comments
 (0)