Skip to content

Commit 69d45d0

Browse files
addressed review comments
1 parent 9bc1bbf commit 69d45d0

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

server/src/main/java/com/cloud/network/element/VirtualRouterElement.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,11 @@ public boolean saveSSHKey(final Network network, final NicProfile nic, final Vir
768768
@Override
769769
public boolean saveHypervisorHostname(NicProfile nicProfile, Network network, VirtualMachineProfile vm, DeployDestination dest) throws ResourceUnavailableException {
770770
final UserDataServiceProvider userDataUpdateProvider = _networkModel.getUserDataUpdateProvider(network);
771-
if (userDataUpdateProvider != null && Provider.VirtualRouter.equals(userDataUpdateProvider.getProvider()) && vm.getVirtualMachine().getType() == VirtualMachine.Type.User) {
771+
if (userDataUpdateProvider == null) {
772+
s_logger.warn("Failed to update hypervisor host details, can't get user data provider");
773+
return false;
774+
}
775+
if (Provider.VirtualRouter.equals(userDataUpdateProvider.getProvider()) && vm.getVirtualMachine().getType() == VirtualMachine.Type.User) {
772776
VirtualMachine uvm = vm.getVirtualMachine();
773777
UserVmVO destVm = _userVmDao.findById(uvm.getId());
774778
VirtualMachineProfile profile = null;

0 commit comments

Comments
 (0)