Added VMs existance check

Author: harikrishna-patnala

server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java

@@ -29,6 +29,7 @@
 import javax.inject.Inject;
 
 import com.cloud.domain.Domain;
+import com.cloud.vm.VMInstanceVO;
 import org.apache.cloudstack.agent.directdownload.CheckUrlAnswer;
 import org.apache.cloudstack.agent.directdownload.CheckUrlCommand;
 import org.apache.cloudstack.annotation.AnnotationService;
@@ -665,6 +666,14 @@ public boolean delete(TemplateProfile profile) {
             // Remove template details
             templateDetailsDao.removeDetails(template.getId());
 
+            // Remove deploy-as-is details (if any and if there are no VMs using it)
+            if (template.isDeployAsIs()) {
+                List<VMInstanceVO> vmInstanceVOList = _vmInstanceDao.listNonExpungedByTemplate(template.getId());
+                if (CollectionUtils.isEmpty(vmInstanceVOList)) {
+                    templateDeployAsIsDetailsDao.removeDetails(template.getId());
+                }
+            }
+
             // Remove comments (if any)
             AnnotationService.EntityType entityType = template.getFormat().equals(ImageFormat.ISO) ?
                     AnnotationService.EntityType.ISO : AnnotationService.EntityType.TEMPLATE;

server/src/main/java/com/cloud/template/TemplateAdapterBase.java

@@ -28,6 +28,7 @@
 import com.cloud.storage.upload.params.TemplateUploadParams;
 import com.cloud.storage.upload.params.UploadParams;
 import com.cloud.vm.VmDetailConstants;
+import com.cloud.vm.dao.VMInstanceDao;
 import org.apache.cloudstack.api.command.user.iso.GetUploadParamsForIsoCmd;
 import org.apache.cloudstack.api.command.user.template.GetUploadParamsForTemplateCmd;
 import org.apache.commons.collections.CollectionUtils;
@@ -123,6 +124,8 @@ public abstract class TemplateAdapterBase extends AdapterBase implements Templat
     ProjectManager _projectMgr;
     @Inject
     private TemplateDataStoreDao templateDataStoreDao;
+    @Inject
+    VMInstanceDao _vmInstanceDao;
 
     @Override
     public boolean stop() {