fix Sensitive Data Exposure Through Exception Logging in OVM Hypervisor Configuration

cyl-auth · cyl-auth · commit 7e7ba5c29577 · 2025-11-08T20:56:44.000+08:00
diff --git a/plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/hypervisor/OvmResourceBase.java b/plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/hypervisor/OvmResourceBase.java
@@ -362,7 +362,7 @@ protected void setupServer() throws IOException {
 
         sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip, _username, _password);
         if (sshConnection == null) {
-            throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=%3$s", _ip, _username, _password));
+            throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=*****", _ip, _username));
         }
 
         if (!SSHCmdHelper.sshExecuteCmd(sshConnection, "sh /usr/bin/configureOvm.sh postSetup")) {

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ protected void setupServer() throws IOException {`
`362`	`362`
`363`	`363`	`sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip, _username, _password);`
`364`	`364`	`if (sshConnection == null) {`
`365`		`- throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=%3$s", _ip, _username, _password));`
	`365`	`+ throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=*****", _ip, _username));`
`366`	`366`	`}`
`367`	`367`
`368`	`368`	`if (!SSHCmdHelper.sshExecuteCmd(sshConnection, "sh /usr/bin/configureOvm.sh postSetup")) {`