revert change to make vm_id nullable in backup table

Author: abh1sar

engine/schema/src/main/java/org/apache/cloudstack/backup/BackupVO.java

@@ -273,11 +273,6 @@ public Map<String, String> getDetails() {
         return details;
     }
 
-    public void setDetail(String name, String value) {
-        assert (details != null) : "Did you forget to load the details?";
-        this.details.put(name, value);
-    }
-
     @Override
     public String getDetail(String name) {
         return this.details.get(name);

engine/schema/src/main/java/org/apache/cloudstack/backup/dao/BackupDaoImpl.java

@@ -54,7 +54,6 @@
 import com.cloud.utils.db.Transaction;
 import com.cloud.utils.db.TransactionCallback;
 import com.cloud.vm.VMInstanceVO;
-import com.cloud.vm.VirtualMachine;
 import com.cloud.vm.dao.VMInstanceDao;
 import com.cloud.network.Network;
 import com.cloud.network.dao.NetworkDao;
@@ -351,9 +350,7 @@ public BackupResponse newBackupResponse(Backup backup, Boolean listVmDetails) {
         response.setName(backup.getName());
         response.setDescription(backup.getDescription());
         response.setVmName(vm.getHostName());
-        if (vm.getState() != VirtualMachine.State.Expunging) {
-            response.setVmId(vm.getUuid());
-        }
+        response.setVmId(vm.getUuid());
         if (vm.getBackupOfferingId() == null || vm.getBackupOfferingId() != backup.getBackupOfferingId()) {
             response.setVmOfferingRemoved(true);
         }

engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql

@@ -244,9 +244,6 @@ ALTER TABLE `cloud`.`backups` MODIFY COLUMN `name` VARCHAR(255) NOT NULL;
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.backups', 'description', 'VARCHAR(1024) COMMENT "description for the backup"');
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.backups', 'backup_interval_type', 'int(5) COMMENT "type of backup, e.g. manual, recurring - hourly, daily, weekly or monthly"');
 
--- Make the column vm_id in backups table nullable to handle orphan backups
-ALTER TABLE `cloud`.`backups` MODIFY COLUMN `vm_id` BIGINT UNSIGNED NULL;
-
 -- Create backup details table
 CREATE TABLE IF NOT EXISTS `cloud`.`backup_details` (
   `id` bigint unsigned NOT NULL auto_increment,