fix tests

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java

@@ -97,7 +97,7 @@ public class SystemVmTemplateRegistration {
     private static final String ABSOLUTE_TEMPLATE_PATH = "/usr/share/cloudstack-management/templates/systemvm/";
     private static final String TEMPLATES_PATH = fetchTemplatesPath();
     private static final String METADATA_FILE_NAME = "metadata.ini";
-    protected static final String METADATA_FILE = TEMPLATES_PATH + METADATA_FILE_NAME;
+    private static final String METADATA_FILE = TEMPLATES_PATH + METADATA_FILE_NAME;
     public static final String TEMPORARY_SECONDARY_STORE = "tmp";
     private static final String PARTIAL_TEMPLATE_FOLDER = String.format("/template/tmpl/%d/", Account.ACCOUNT_ID_SYSTEM);
     private static final String storageScriptsDir = "scripts/storage/secondary";
@@ -774,16 +774,21 @@ public void validateAndRegisterTemplateForNonExistingEntries(Hypervisor.Hypervis
         registerTemplateForNonExistingEntries(hypervisor, arch, name, storeUrlAndId, filePath);
     }
 
+    protected static String getMetadataFilePath() {
+        return METADATA_FILE;
+    }
+
     /**
      * This method parses the metadata file consisting of the systemVM templates information
      * @return the version of the systemvm template that is to be used. This is done in order
      * to fallback on the latest available version of the systemVM template when there doesn't
      * exist a template corresponding to the current code version.
      */
     public static String parseMetadataFile() {
-        String errMsg = String.format("Failed to parse systemVM template metadata file: %s", METADATA_FILE);
+        String metadataFilePath = getMetadataFilePath();
+        String errMsg = String.format("Failed to parse systemVM template metadata file: %s", metadataFilePath);
         final Ini ini = new Ini();
-        try (FileReader reader = new FileReader(METADATA_FILE)) {
+        try (FileReader reader = new FileReader(metadataFilePath)) {
             ini.load(reader);
         } catch (IOException e) {
             LOGGER.error(errMsg, e);
@@ -798,7 +803,8 @@ public static String parseMetadataFile() {
             String key = getHypervisorArchKey(hypervisorType.first(), hypervisorType.second());
             Ini.Section section = ini.get(key);
             if (section == null) {
-                LOGGER.error("Failed to find details for {} in template metadata file: {}", key, METADATA_FILE);
+                LOGGER.error("Failed to find details for {} in template metadata file: {}",
+                        key, metadataFilePath);
                 continue;
             }
             NewTemplateMap.put(key, new MetadataTemplateDetails(

engine/schema/src/test/java/com/cloud/upgrade/SystemVmTemplateRegistrationTest.java

@@ -34,9 +34,6 @@
 import static org.mockito.Mockito.when;
 
 import java.io.File;
-import java.io.IOException;
-import java.lang.reflect.Field;
-import java.lang.reflect.Modifier;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -45,6 +42,7 @@
 
 import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreVO;
 import org.apache.cloudstack.utils.security.DigestHelper;
+import org.apache.commons.lang3.StringUtils;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
@@ -78,48 +76,41 @@ public class SystemVmTemplateRegistrationTest {
     @InjectMocks
     SystemVmTemplateRegistration systemVmTemplateRegistration = new SystemVmTemplateRegistration();
 
-    private void setupMetadataFile(boolean create) {
+    private void setupMetadataFile(MockedStatic<SystemVmTemplateRegistration> mockedStatic, String content) {
         try {
             String location = "metadata.ini";
-            if (create) {
+            if (StringUtils.isNotBlank(content)) {
                 File tempFile = File.createTempFile("metadata", ".ini");
                 location = tempFile.getAbsolutePath();
+                Files.write(Paths.get(location), content.getBytes());
+                tempFile.deleteOnExit();
             }
-            Field field = SystemVmTemplateRegistration.class.getDeclaredField("METADATA_FILE");
-            Field modifiersField = Field.class.getDeclaredField("modifiers");
-            modifiersField.setAccessible(true);
-            modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);
-            field.setAccessible(true);
-            field.set(null, location);
+            mockedStatic.when(SystemVmTemplateRegistration::getMetadataFilePath).thenReturn(location);
         } catch (Exception e) {
             fail(e.getMessage());
         }
     }
 
-    private void updateMetadataContent(String content) {
-        try {
-            Files.write(Paths.get(SystemVmTemplateRegistration.METADATA_FILE), content.getBytes());
-        } catch (IOException e) {
-            fail(e.getMessage());
-        }
-    }
-
     @Test
     public void test_parseMetadataFile_noFile() {
-        setupMetadataFile(false);
-        CloudRuntimeException exception = assertThrows(CloudRuntimeException.class,
-                SystemVmTemplateRegistration::parseMetadataFile);
-        assertTrue(exception.getMessage().contains("Failed to parse systemVM template metadata file"));
+        try (MockedStatic<SystemVmTemplateRegistration> mockedStatic =
+                     Mockito.mockStatic(SystemVmTemplateRegistration.class, Mockito.CALLS_REAL_METHODS)) {
+            setupMetadataFile(mockedStatic, null);
+            CloudRuntimeException exception = assertThrows(CloudRuntimeException.class,
+                    SystemVmTemplateRegistration::parseMetadataFile);
+            assertTrue(exception.getMessage().contains("Failed to parse systemVM template metadata file"));
+        }
     }
 
     @Test
     public void test_parseMetadataFile_invalidContent() {
-        setupMetadataFile(true);
-        String metadataFileContent = "abc";
-        updateMetadataContent(metadataFileContent);
-        CloudRuntimeException exception = assertThrows(CloudRuntimeException.class,
-                SystemVmTemplateRegistration::parseMetadataFile);
-        assertTrue(exception.getMessage().contains("Failed to parse systemVM template metadata file"));
+        try (MockedStatic<SystemVmTemplateRegistration> mockedStatic =
+                     Mockito.mockStatic(SystemVmTemplateRegistration.class, Mockito.CALLS_REAL_METHODS)) {
+            setupMetadataFile(mockedStatic, "abc");
+            CloudRuntimeException exception = assertThrows(CloudRuntimeException.class,
+                    SystemVmTemplateRegistration::parseMetadataFile);
+            assertTrue(exception.getMessage().contains("Failed to parse systemVM template metadata file"));
+        }
     }
 
     @Test
@@ -144,10 +135,12 @@ public void test_parseMetadataFile_success() {
                 "checksum = abc3\n" +
                 "downloadurl = https://download.cloudstack.org/systemvm/x.y/systemvmtemplate-x.y.z-vmware.ova\n" +
                 "filename = systemvmtemplate-x.y.z-vmware.ova\n";
-        setupMetadataFile(true);
-        updateMetadataContent(metadataFileContent);
-        String version = SystemVmTemplateRegistration.parseMetadataFile();
-        assertEquals("x.y.z.0", version);
+        try (MockedStatic<SystemVmTemplateRegistration> mockedStatic =
+                     Mockito.mockStatic(SystemVmTemplateRegistration.class, Mockito.CALLS_REAL_METHODS)) {
+            setupMetadataFile(mockedStatic, metadataFileContent);
+            String version = SystemVmTemplateRegistration.parseMetadataFile();
+            assertEquals("x.y.z.0", version);
+        }
         assertNull(SystemVmTemplateRegistration.NewTemplateMap.get("xenserver"));
         SystemVmTemplateRegistration.MetadataTemplateDetails templateDetails =
                 SystemVmTemplateRegistration.NewTemplateMap.get("kvm-x86_64");