Fix ConfigurationVO load exception after schema change (#10485)

Author: abh1sar

engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java

@@ -379,6 +379,9 @@ private VersionVO executeUpgrade(DbUpgrade upgrade) {
         } finally {
             txn.close();
         }
+        if (upgrade.refreshPoolConnectionsAfterUpgrade()) {
+            TransactionLegacy.refreshConnections(TransactionLegacy.CLOUD_DB);
+        }
         return version;
     }
 

engine/schema/src/main/java/com/cloud/upgrade/dao/DbUpgrade.java

@@ -38,4 +38,8 @@ public interface DbUpgrade {
     void performDataMigration(Connection conn);
 
     InputStream[] getCleanupScripts();
+
+    default boolean refreshPoolConnectionsAfterUpgrade() {
+        return false;
+    }
 }

engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42010to42100.java

@@ -16,10 +16,6 @@
 // under the License.
 package com.cloud.upgrade.dao;
 
-import com.cloud.upgrade.SystemVmTemplateRegistration;
-import com.cloud.utils.db.TransactionLegacy;
-import com.cloud.utils.exception.CloudRuntimeException;
-
 import java.io.InputStream;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
@@ -32,6 +28,10 @@
 
 import org.apache.cloudstack.framework.config.ConfigKey;
 
+import com.cloud.upgrade.SystemVmTemplateRegistration;
+import com.cloud.utils.db.TransactionLegacy;
+import com.cloud.utils.exception.CloudRuntimeException;
+
 public class Upgrade42010to42100 extends DbUpgradeAbstractImpl implements DbUpgrade, DbUpgradeSystemVmTemplate {
     private SystemVmTemplateRegistration systemVmTemplateRegistration;
 
@@ -212,4 +212,9 @@ protected void migrateExistingConfigurationScopeValues(Connection conn) {
             throw new CloudRuntimeException(String.format("Failed to migrate existing configuration scope values to bitmask due to: %s", e.getMessage()));
         }
     }
+
+    @Override
+    public boolean refreshPoolConnectionsAfterUpgrade() {
+        return true;
+    }
 }

framework/config/src/test/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImplTest.java

@@ -107,7 +107,6 @@ private void runTestGetConfigStringValueExpiry(long wait, int configDBRetrieval)
         String result = configDepotImpl.getConfigStringValue(key, ConfigKey.Scope.Global, null);
         Assert.assertEquals(value, result);
         Mockito.verify(_configDao, Mockito.times(configDBRetrieval)).findById(key);
-
     }
 
     @Test

framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java

@@ -605,6 +605,15 @@ public Connection getConnection() throws SQLException {
         return _conn;
     }
 
+    public static void refreshConnections(final short dbId) {
+        if (dbId != CLOUD_DB) {
+            return;
+        }
+        if (s_ds instanceof HikariDataSource) {
+            ((HikariDataSource)s_ds).getHikariPoolMXBean().softEvictConnections();
+        }
+    }
+
     protected boolean takeOver(final String name, final boolean create) {
         if (_stack.size() != 0) {
             if (!create) {