fix failing tests

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java

@@ -120,8 +120,8 @@ public Map<String, String> getExternalDetails() {
         return convertExternalDetailsToMap(externalDetails);
     }
 
-    public Boolean isCleanupExternalDetails() {
-        return cleanupExternalDetails;
+    public boolean isCleanupExternalDetails() {
+        return Boolean.TRUE.equals(cleanupExternalDetails);
     }
 
     /////////////////////////////////////////////////////

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java

@@ -213,8 +213,8 @@ public Map<String, String> getExternalDetails() {
         return convertExternalDetailsToMap(externalDetails);
     }
 
-    public Boolean isCleanupExternalDetails() {
-        return cleanupExternalDetails;
+    public boolean isCleanupExternalDetails() {
+        return Boolean.TRUE.equals(cleanupExternalDetails);
     }
 
     /////////////////////////////////////////////////////

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

@@ -2800,8 +2800,8 @@ private void updateHostTags(HostVO host, Long hostId, List<String> hostTags, Boo
     @Override
     public Host updateHost(final UpdateHostCmd cmd) throws NoTransitionException {
         return updateHost(cmd.getId(), cmd.getName(), cmd.getOsCategoryId(), cmd.getAllocationState(), cmd.getUrl(),
-                cmd.getHostTags(), cmd.getIsTagARule(), cmd.getAnnotation(), false, cmd.getExternalDetails(),
-                cmd.isCleanupExternalDetails());
+                cmd.getHostTags(), cmd.getIsTagARule(), cmd.getAnnotation(), false,
+                cmd.getExternalDetails(), cmd.isCleanupExternalDetails());
     }
 
     private Host updateHost(Long hostId, String name, Long guestOSCategoryId, String allocationState,