review comments

Author: abh1sar

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/CreateVMFromBackupCmdByAdmin.java

@@ -39,10 +39,10 @@
         authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
 public class CreateVMFromBackupCmdByAdmin extends CreateVMFromBackupCmd implements AdminCmd {
 
-    @Parameter(name = ApiConstants.POD_ID, type = CommandType.UUID, entityType = PodResponse.class, description = "destination Pod ID to deploy the VM to - parameter available for root admin only", since = "4.13")
+    @Parameter(name = ApiConstants.POD_ID, type = CommandType.UUID, entityType = PodResponse.class, description = "destination Pod ID to deploy the VM to - parameter available for root admin only", since = "4.21")
     private Long podId;
 
-    @Parameter(name = ApiConstants.CLUSTER_ID, type = CommandType.UUID, entityType = ClusterResponse.class, description = "destination Cluster ID to deploy the VM to - parameter available for root admin only", since = "4.13")
+    @Parameter(name = ApiConstants.CLUSTER_ID, type = CommandType.UUID, entityType = ClusterResponse.class, description = "destination Cluster ID to deploy the VM to - parameter available for root admin only", since = "4.21")
     private Long clusterId;
 
     public Long getPodId() {

api/src/main/java/org/apache/cloudstack/api/command/user/vm/CreateVMFromBackupCmd.java

@@ -50,9 +50,6 @@
         authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User})
 public class CreateVMFromBackupCmd extends BaseDeployVMCmd {
 
-    @Inject
-    BackupManager backupManager;
-
     /////////////////////////////////////////////////////
     //////////////// API parameters /////////////////////
     /////////////////////////////////////////////////////

api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java

@@ -104,13 +104,13 @@ public interface BackupProvider {
     void syncBackupMetrics(Long zoneId);
 
     /**
-     * This method should TODO
-     * @param vm the machine to get restore point for
+     * Returns a list of Backup.RestorePoint
+     * @param vm the machine to get the restore points for
      */
     List<Backup.RestorePoint> listRestorePoints(VirtualMachine vm);
 
     /**
-     * This method should TODO
+     * Creates and returns an entry in the backups table by getting the information from restorePoint and vm.
      *
      * @param restorePoint the restore point to create a backup for
      * @param vm           The machine for which to create a backup