Skip to content

Commit a44dde0

Browse files
committed
Address review comments
1 parent dabd833 commit a44dde0

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,8 +434,8 @@ private IpAddress getSourceNatIp(Network network) {
434434
}
435435

436436
public VMTemplateVO getKubernetesServiceTemplate(DataCenter dataCenter, Hypervisor.HypervisorType hypervisorType) {
437-
ConfigKey<String> preferredArchitecture = ResourceManager.SystemVmPreferredArchitecture;
438-
VMTemplateVO template = templateDao.findSystemVMReadyTemplate(dataCenter.getId(), hypervisorType, preferredArchitecture.value());
437+
String preferredArchitecture = ResourceManager.SystemVmPreferredArchitecture.valueIn(dataCenter.getId());
438+
VMTemplateVO template = templateDao.findSystemVMReadyTemplate(dataCenter.getId(), hypervisorType, preferredArchitecture);
439439
if (DataCenter.Type.Edge.equals(dataCenter.getType()) && template != null && !template.isDirectDownload()) {
440440
logger.debug(String.format("Template %s can not be used for edge zone %s", template, dataCenter));
441441
template = templateDao.findRoutingTemplate(hypervisorType, networkHelper.getHypervisorRouterTemplateConfigMap().get(hypervisorType).valueIn(dataCenter.getId()));

plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ protected DeployDestination plan(final long nodesCount, final DataCenter zone, f
248248
for (Map.Entry<String, Pair<HostVO, Integer>> hostEntry : hosts_with_resevered_capacity.entrySet()) {
249249
Pair<HostVO, Integer> hp = hostEntry.getValue();
250250
HostVO h = hp.first();
251-
if (!h.getHypervisorType().equals(clusterTemplate.getHypervisorType())) {
251+
if (!h.getHypervisorType().equals(clusterTemplate.getHypervisorType()) || !h.getArch().equals(clusterTemplate.getArch())) {
252252
continue;
253253
}
254254
hostDao.loadHostTags(h);

plugins/storage/sharedfs/storagevm/src/main/java/org/apache/cloudstack/storage/sharedfs/lifecycle/StorageVmSharedFSLifeCycle.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
import org.apache.cloudstack.api.ApiCommandResourceType;
6262
import org.apache.cloudstack.api.BaseCmd;
6363
import org.apache.cloudstack.context.CallContext;
64-
import org.apache.cloudstack.framework.config.ConfigKey;
6564
import org.apache.cloudstack.storage.sharedfs.SharedFS;
6665
import org.apache.cloudstack.storage.sharedfs.SharedFSLifeCycle;
6766
import org.apache.commons.codec.binary.Base64;
@@ -175,11 +174,11 @@ private UserVm deploySharedFSVM(Long zoneId, Account owner, List<Long> networkId
175174
customParameterMap.put("maxIopsDo", maxIops.toString());
176175
}
177176
List<String> keypairs = new ArrayList<String>();
178-
ConfigKey<String> preferredArchitecture = ResourceManager.SystemVmPreferredArchitecture;
177+
String preferredArchitecture = ResourceManager.SystemVmPreferredArchitecture.valueIn(zoneId);
179178

180179
for (final Iterator<Hypervisor.HypervisorType> iter = hypervisors.iterator(); iter.hasNext();) {
181180
final Hypervisor.HypervisorType hypervisor = iter.next();
182-
VMTemplateVO template = templateDao.findSystemVMReadyTemplate(zoneId, hypervisor, preferredArchitecture.value());
181+
VMTemplateVO template = templateDao.findSystemVMReadyTemplate(zoneId, hypervisor, preferredArchitecture);
183182
if (template == null && !iter.hasNext()) {
184183
throw new CloudRuntimeException(String.format("Unable to find the systemvm template for %s or it was not downloaded in %s.", hypervisor.toString(), zone.toString()));
185184
}

0 commit comments

Comments
 (0)