Skip to content

Commit a828539

Browse files
committed
address review
Signed-off-by: Abhishek Kumar <[email protected]>
1 parent d0d9459 commit a828539

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

ui/src/main.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ import {
4040
dialogUtilPlugin,
4141
cpuArchitectureUtilPlugin,
4242
imagesUtilPlugin,
43-
extensionsUtilPlugin
43+
extensionsUtilPlugin,
44+
backupUtilPlugin
4445
} from './utils/plugins'
4546
import { VueAxios } from './utils/request'
4647
import directives from './utils/directives'
@@ -63,6 +64,7 @@ vueApp.use(dialogUtilPlugin)
6364
vueApp.use(cpuArchitectureUtilPlugin)
6465
vueApp.use(imagesUtilPlugin)
6566
vueApp.use(extensionsUtilPlugin)
67+
vueApp.use(backupUtilPlugin)
6668
vueApp.use(extensions)
6769
vueApp.use(directives)
6870

ui/src/utils/plugins.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,3 +597,14 @@ export const extensionsUtilPlugin = {
597597
}
598598
}
599599
}
600+
601+
export const backupUtilPlugin = {
602+
install (app) {
603+
app.config.globalProperties.$isBackupProviderSupportsQuiesceVm = function (provider) {
604+
if (!provider && typeof provider !== 'string') {
605+
return false
606+
}
607+
return ['nas'].includes(provider.toLowerCase())
608+
}
609+
}
610+
}

ui/src/views/compute/backup/FormSchedule.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
</a-form-item>
134134
</a-col>
135135
<a-col :md="24" :lg="12">
136-
<a-form-item v-if="backupProvider === 'nas'" name="quiescevm" ref="quiescevm">
136+
<a-form-item v-if="isQuiesceVmSupported" name="quiescevm" ref="quiescevm">
137137
<a-switch v-model:checked="form.quiescevm"/>
138138
<template #label>
139139
<tooltip-label :title="$t('label.quiescevm')" :tooltip="apiParams.quiescevm.description"/>
@@ -211,6 +211,11 @@ export default {
211211
this.fetchBackupOffering()
212212
},
213213
inject: ['refreshSchedule', 'closeSchedule'],
214+
computed: {
215+
isQuiesceVmSupported () {
216+
return this.$isBackupProviderSupportsQuiesceVm(this.backupProvider)
217+
}
218+
},
214219
methods: {
215220
initForm () {
216221
this.formRef = ref()

0 commit comments

Comments
 (0)