code improvements, and logs

Author: sureshanaparti

agent/src/main/java/com/cloud/agent/Agent.java

@@ -476,7 +476,7 @@ private void scheduleHostLBCheckerTask(final String lbAlgorithm, final long chec
                 return;
             }
 
-            logger.info("Scheduling a recurring preferred host checker task with lb algorithm '{}' and host.lb.interval={} ms", lbAlgorithm, checkInterval);
+            logger.info("Scheduling a recurring preferred host checker task with host.lb.interval={} ms", checkInterval);
             hostLbCheckExecutor = Executors.newSingleThreadScheduledExecutor((new NamedThreadFactory(name)));
             hostLbCheckExecutor.scheduleAtFixedRate(new PreferredHostCheckerTask(), checkInterval, checkInterval,
                     TimeUnit.MILLISECONDS);

core/src/main/java/com/cloud/agent/api/ReadyCommand.java

@@ -26,10 +26,6 @@
 public class ReadyCommand extends Command {
     private String _details;
 
-    public ReadyCommand() {
-        super();
-    }
-
     private Long dcId;
     private Long hostId;
     private String hostUuid;
@@ -41,6 +37,10 @@ public ReadyCommand() {
     private Boolean enableHumanReadableSizes;
     private String arch;
 
+    public ReadyCommand() {
+        super();
+    }
+
     public ReadyCommand(Long dcId) {
         super();
         this.dcId = dcId;
@@ -95,7 +95,7 @@ public List<String> getAvoidMsHostList() {
         return avoidMsHostList;
     }
 
-    public void setAvoidMsHostList(List<String> msHostList) {
+    public void setAvoidMsHostList(List<String> avoidMsHostList) {
         this.avoidMsHostList = avoidMsHostList;
     }
 

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

@@ -758,15 +758,15 @@ public void notifyMonitorsOfNewlyAddedHost(long hostId) {
         }
     }
 
-    protected AgentAttache notifyMonitorsOfConnection(final AgentAttache attache, final StartupCommand[] cmd, final boolean forRebalance) throws ConnectionException {
+    protected AgentAttache notifyMonitorsOfConnection(final AgentAttache attache, final StartupCommand[] cmds, final boolean forRebalance) throws ConnectionException {
         final long hostId = attache.getId();
         final HostVO host = _hostDao.findById(hostId);
         for (final Pair<Integer, Listener> monitor : _hostMonitors) {
             logger.debug("Sending Connect to listener: {}, for rebalance: {}", monitor.second().getClass().getSimpleName(), forRebalance);
-            for (int i = 0; i < cmd.length; i++) {
+            for (StartupCommand cmd : cmds) {
                 try {
-                    logger.debug("process connection to issue: {} for host: {}, forRebalance: {}, connection transferred: {}", ReflectionToStringBuilderUtils.reflectCollection(cmd[i]), hostId, forRebalance, cmd[i].isConnectionTransferred());
-                    monitor.second().processConnect(host, cmd[i], forRebalance);
+                    logger.debug("process connection to issue: {} for host: {}, forRebalance: {}", ReflectionToStringBuilderUtils.reflectOnlySelectedFields(cmd, "id", "type", "msHostList", "connectionTransferred"), hostId, forRebalance);
+                    monitor.second().processConnect(host, cmd, forRebalance);
                 } catch (final ConnectionException ce) {
                     if (ce.isSetupError()) {
                         logger.warn("Monitor {} says there is an error in the connect process for {} due to {}", monitor.second().getClass().getSimpleName(), hostId, ce.getMessage());
@@ -1677,7 +1677,7 @@ protected void processRequest(final Link link, final Request request) {
                                     logger.debug("Not processing {} for agent id={}; can't find the host in the DB", PingRoutingCommand.class.getSimpleName(), cmdHostId);
                                 }
                             }
-                            if (host!= null && host.getStatus() != Status.Up && gatewayAccessible) {
+                            if (host != null && host.getStatus() != Status.Up && gatewayAccessible) {
                                 requestStartupCommand = true;
                             }
                             final List<String> avoidMsList = _mshostDao.listNonUpStateMsIPs();

engine/orchestration/src/main/java/com/cloud/agent/manager/ConnectedAgentAttache.java

@@ -54,8 +54,10 @@ public synchronized boolean isClosed() {
     @Override
     public void disconnect(final Status state) {
         synchronized (this) {
-            logger.debug("Processing Disconnect.");
+            logger.debug("Processing disconnect [id: {}, uuid: {}, name: {}]", _id, _uuid, _name);
+
             if (_link != null) {
+                logger.debug("Disconnecting from {}, Socket Address: {}", _link.getIpAddress(), _link.getSocketAddress());
                 _link.close();
                 _link.terminated();
             }