Get volume physical size from StatsCollector for checking backup resource limit

Author: abh1sar

api/src/main/java/com/cloud/storage/VolumeApiService.java

@@ -190,4 +190,6 @@ Volume updateVolume(long volumeId, String path, String state, Long storageId,
     boolean stateTransitTo(Volume vol, Volume.Event event) throws NoTransitionException;
 
     Pair<String, String> checkAndRepairVolume(CheckAndRepairVolumeCmd cmd) throws ResourceAllocationException;
+
+    Long getVolumePhysicalUsed(Storage.ImageFormat format, String path, String chainInfo);
 }

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

@@ -161,6 +161,7 @@
 import com.cloud.serializer.GsonHelper;
 import com.cloud.server.ManagementService;
 import com.cloud.server.ResourceTag;
+import com.cloud.server.StatsCollector;
 import com.cloud.server.TaggedResourceService;
 import com.cloud.service.ServiceOfferingVO;
 import com.cloud.service.dao.ServiceOfferingDao;
@@ -347,7 +348,8 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
     protected StoragePoolDetailsDao storagePoolDetailsDao;
     @Inject
     private BackupDao backupDao;
-
+    @Inject
+    private StatsCollector statsCollector;
 
     protected Gson _gson;
 
@@ -5154,6 +5156,21 @@ private VmWorkJobVO createPlaceHolderWork(long instanceId) {
         return workJob;
     }
 
+    @Override
+    public Long getVolumePhysicalUsed(ImageFormat format, String path, String chainInfo) {
+        VolumeStats vs = null;
+        if (format == ImageFormat.VHD || format == ImageFormat.QCOW2 || format == ImageFormat.RAW) {
+            if (path != null) {
+                vs = statsCollector.getVolumeStats(path);
+            }
+        } else if (format == ImageFormat.OVA) {
+            if (chainInfo != null) {
+                vs = statsCollector.getVolumeStats(chainInfo);
+            }
+        }
+        return (vs == null) ? null : vs.getPhysicalSize();
+    }
+
     @Override
     public String getConfigComponentName() {
         return VolumeApiService.class.getSimpleName();

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

@@ -585,7 +585,11 @@ public boolean createBackup(final Long vmId, final Long scheduleId) throws Resou
         Long backupSize = 0L;
         for (final Volume volume: volumeDao.findByInstance(vmId)) {
             if (Volume.State.Ready.equals(volume.getState())) {
-                backupSize += volume.getSize();
+                Long volumeSize = volumeApiService.getVolumePhysicalUsed(volume.getFormat(), volume.getPath(), volume.getChainInfo());
+                if (volumeSize == null) {
+                    volumeSize = volume.getSize();
+                }
+                backupSize += volumeSize;
             }
         }
         try {