Remove unnecessary parenthesis

winterhazel · winterhazel · commit b76dbcd02860 · 2024-11-01T09:21:57.000-03:00
diff --git a/server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java b/server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java
@@ -407,7 +407,7 @@ public void detectRulesConflict(FirewallRule newRule) throws NetworkRuleConflict
                 _firewallDao.loadDestinationCidrs(rule);
                 _firewallDao.loadDestinationCidrs((FirewallRuleVO) newRule);
 
-                duplicatedCidrs = (detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList()));
+                duplicatedCidrs = detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList());
             }
 
             boolean bothRulesPortForwarding = rule.getPurpose() == newRule.getPurpose() && rule.getPurpose() == Purpose.PortForwarding;

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,7 @@ public void detectRulesConflict(FirewallRule newRule) throws NetworkRuleConflict`
`407`	`407`	`_firewallDao.loadDestinationCidrs(rule);`
`408`	`408`	`_firewallDao.loadDestinationCidrs((FirewallRuleVO) newRule);`
`409`	`409`
`410`		`- duplicatedCidrs = (detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList()));`
	`410`	`+ duplicatedCidrs = detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList());`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`boolean bothRulesPortForwarding = rule.getPurpose() == newRule.getPurpose() && rule.getPurpose() == Purpose.PortForwarding;`