server: fix volume offering not updated after offering change

shwstppr · shwstppr · commit b963eb88cede · 2025-11-11T18:04:11.000+05:30
Fixes #10950 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
diff --git a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
@@ -1536,6 +1536,7 @@ private VolumeVO orchestrateResizeVolume(long volumeId, long currentSize, long n
                 }
             }
 
+            volume = _volsDao.findById(volumeId);
             if (newDiskOfferingId != null) {
                 volume.setDiskOfferingId(newDiskOfferingId);
                 _volumeMgr.saveVolumeDetails(newDiskOfferingId, volume.getId());
@@ -1550,7 +1551,6 @@ private VolumeVO orchestrateResizeVolume(long volumeId, long currentSize, long n
             }
 
             // Update size if volume has same size as before, else it is already updated
-            volume = _volsDao.findById(volumeId);
             if (currentSize == volume.getSize() && currentSize != newSize) {
                 volume.setSize(newSize);
             } else if (volume.getSize() != newSize) {

Original file line number	Diff line number	Diff line change
`@@ -1536,6 +1536,7 @@ private VolumeVO orchestrateResizeVolume(long volumeId, long currentSize, long n`
`1536`	`1536`	`}`
`1537`	`1537`	`}`
`1538`	`1538`
	`1539`	`+ volume = _volsDao.findById(volumeId);`
`1539`	`1540`	`if (newDiskOfferingId != null) {`
`1540`	`1541`	`volume.setDiskOfferingId(newDiskOfferingId);`
`1541`	`1542`	`_volumeMgr.saveVolumeDetails(newDiskOfferingId, volume.getId());`
`@@ -1550,7 +1551,6 @@ private VolumeVO orchestrateResizeVolume(long volumeId, long currentSize, long n`
`1550`	`1551`	`}`
`1551`	`1552`
`1552`	`1553`	`// Update size if volume has same size as before, else it is already updated`
`1553`		`- volume = _volsDao.findById(volumeId);`
`1554`	`1554`	`if (currentSize == volume.getSize() && currentSize != newSize) {`
`1555`	`1555`	`volume.setSize(newSize);`
`1556`	`1556`	`} else if (volume.getSize() != newSize) {`