address copilot

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

server/src/main/java/com/cloud/api/ApiServlet.java

@@ -498,7 +498,9 @@ protected boolean isStateChangingCommandNotUsingPOST(String command, String meth
                     commandHttpMethod = at.httpMethod();
                 }
             }
-        } catch (CloudRuntimeException ignored) {}
+        } catch (CloudRuntimeException e) {
+            LOGGER.trace("Command class not found for {}; falling back to pattern match", command, e);
+        }
         if (BaseCmd.HTTPMethod.GET.toString().equalsIgnoreCase(commandHttpMethod) ||
                 GET_REQUEST_COMMANDS.matcher(command.toLowerCase()).matches()) {
             return false;

server/src/test/java/com/cloud/api/ApiServletTest.java

@@ -65,6 +65,9 @@
 @RunWith(MockitoJUnitRunner.class)
 public class ApiServletTest {
 
+    private static final String[] STATE_CHANGING_COMMAND_CHECK_NAME_PARAM =
+            {ApiServer.EnforcePostRequestsAndTimestamps.key()};
+
     @Mock
     ApiServer apiServer;
 
@@ -496,7 +499,7 @@ public void isStateChangingCommandNotUsingPOSTReturnsFalseForUpdateConfiguration
         String command = "updateConfiguration";
         String method = "GET";
         Map<String, Object[]> params = new HashMap<>();
-        params.put("name", new String[] { ApiServer.EnforcePostRequestsAndTimestamps.key() });
+        params.put("name", STATE_CHANGING_COMMAND_CHECK_NAME_PARAM);
         boolean result = servlet.isStateChangingCommandNotUsingPOST(command, method, params);
         Assert.assertFalse(result);
     }
@@ -506,7 +509,7 @@ public void isStateChangingCommandNotUsingPOSTReturnsFalseForWrongApiEnforcePost
         String command = "updateSomeApi";
         String method = "GET";
         Map<String, Object[]> params = new HashMap<>();
-        params.put("name", new String[] { ApiServer.EnforcePostRequestsAndTimestamps.key() });
+        params.put("name", STATE_CHANGING_COMMAND_CHECK_NAME_PARAM);
         boolean result = servlet.isStateChangingCommandNotUsingPOST(command, method, params);
         Assert.assertTrue(result);
     }