Skip to content

Commit bf9737c

Browse files
committed
Fix null on putAll
1 parent 4c49ea2 commit bf9737c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858

5959
import java.util.List;
6060
import java.util.Map;
61+
import java.util.Optional;
6162

6263
public class DefaultHostListener implements HypervisorHostListener {
6364
protected Logger logger = LogManager.getLogger(getClass());
@@ -130,8 +131,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO networkVO, NetworkOffe
130131
public boolean hostConnect(long hostId, long poolId) throws StorageConflictException {
131132
StoragePool pool = (StoragePool) this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
132133
Map<String, String> detailsMap = storagePoolDetailsDao.listDetailsKeyPairs(poolId);
133-
detailsMap.putAll(storageManager.getStoragePoolNFSMountOpts(pool, null).first());
134+
Map<String, String> nfsMountOpts = storageManager.getStoragePoolNFSMountOpts(pool, null).first();
134135

136+
Optional.ofNullable(nfsMountOpts).ifPresent(detailsMap::putAll);
135137
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true, pool, detailsMap);
136138
cmd.setWait(modifyStoragePoolCommandWait);
137139

0 commit comments

Comments
 (0)