fix npe in capacity calculation

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDao.java

@@ -183,8 +183,6 @@ List<VMInstanceVO> searchRemovedByRemoveDate(final Date startDate, final Date en
 
     List<VMInstanceVO> listIdServiceOfferingForVmsMigratingFromHost(Long hostId);
 
-    List<VMInstanceVO> listIdServiceOfferingForVmsByLastHostId(Long hostId);
-
     Map<String, Long> getNameIdMapForVmInstanceNames(Collection<String> names);
 
     Map<String, Long> getNameIdMapForVmIds(Collection<Long> ids);

engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java

@@ -1198,14 +1198,6 @@ public List<VMInstanceVO> listIdServiceOfferingForVmsMigratingFromHost(Long host
         return customSearch(sc, null);
     }
 
-    @Override
-    public List<VMInstanceVO> listIdServiceOfferingForVmsByLastHostId(Long hostId) {
-        SearchCriteria<VMInstanceVO> sc = IdServiceOfferingIdSelectSearch.create();
-        sc.setParameters("lastHost", hostId);
-        sc.setParameters("state", State.Stopped);
-        return customSearch(sc, null);
-    }
-
     @Override
     public Map<String, Long> getNameIdMapForVmInstanceNames(Collection<String> names) {
         SearchBuilder<VMInstanceVO> sb = createSearchBuilder();

server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java

@@ -728,7 +728,7 @@ public void updateCapacityForHost(final Host host) {
             }
         }
 
-        List<VMInstanceVO> vmsByLastHostId = _vmDao.listIdServiceOfferingForVmsByLastHostId(host.getId());
+        List<VMInstanceVO> vmsByLastHostId = _vmDao.listByLastHostId(host.getId());
         logger.debug("Found {} VM, not running on {}", vmsByLastHostId.size(), host);
 
         for (VMInstanceVO vm : vmsByLastHostId) {