@@ -39,98 +39,98 @@ public void allowsRequestWhenTokenIsNotRequiredAndParametersAreMissing() throws
3939 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
4040 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
4141 FilterChain mockChain = mock (FilterChain .class );
42-
42+
4343 when (mockRequest .getParameter ("exp" )).thenReturn (null );
4444 when (mockRequest .getParameter ("sig" )).thenReturn (null );
45-
45+
4646 filter .doFilter (mockRequest , mockResponse , mockChain );
47-
47+
4848 verify (mockChain ).doFilter (mockRequest , mockResponse );
4949 }
50-
50+
5151 @ Test
5252 public void deniesRequestWhenTokenIsRequiredAndParametersAreMissing () throws Exception {
5353 ShareSignedUrlFilter filter = new ShareSignedUrlFilter (true , "secret" );
5454 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
5555 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
5656 FilterChain mockChain = mock (FilterChain .class );
57-
57+
5858 when (mockRequest .getParameter ("exp" )).thenReturn (null );
5959 when (mockRequest .getParameter ("sig" )).thenReturn (null );
60-
60+
6161 filter .doFilter (mockRequest , mockResponse , mockChain );
62-
62+
6363 verify (mockResponse ).sendError (HttpServletResponse .SC_FORBIDDEN , "Missing token" );
6464 verifyNoInteractions (mockChain );
6565 }
66-
66+
6767 @ Test
6868 public void deniesRequestWhenExpirationIsInvalid () throws Exception {
6969 ShareSignedUrlFilter filter = new ShareSignedUrlFilter (true , "secret" );
7070 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
7171 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
7272 FilterChain mockChain = mock (FilterChain .class );
73-
73+
7474 when (mockRequest .getParameter ("exp" )).thenReturn ("invalid" );
7575 when (mockRequest .getParameter ("sig" )).thenReturn ("signature" );
76-
76+
7777 filter .doFilter (mockRequest , mockResponse , mockChain );
78-
78+
7979 verify (mockResponse ).sendError (HttpServletResponse .SC_FORBIDDEN , "Bad exp" );
8080 verifyNoInteractions (mockChain );
8181 }
82-
82+
8383 @ Test
8484 public void deniesRequestWhenTokenIsExpired () throws Exception {
8585 ShareSignedUrlFilter filter = new ShareSignedUrlFilter (true , "secret" );
8686 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
8787 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
8888 FilterChain mockChain = mock (FilterChain .class );
89-
89+
9090 when (mockRequest .getParameter ("exp" )).thenReturn (String .valueOf (Instant .now ().getEpochSecond () - 10 ));
9191 when (mockRequest .getParameter ("sig" )).thenReturn ("signature" );
92-
92+
9393 filter .doFilter (mockRequest , mockResponse , mockChain );
94-
94+
9595 verify (mockResponse ).sendError (HttpServletResponse .SC_FORBIDDEN , "Token expired" );
9696 verifyNoInteractions (mockChain );
9797 }
98-
98+
9999 @ Test
100100 public void deniesRequestWhenSignatureIsInvalid () throws Exception {
101101 ShareSignedUrlFilter filter = new ShareSignedUrlFilter (true , "secret" );
102102 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
103103 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
104104 FilterChain mockChain = mock (FilterChain .class );
105-
105+
106106 when (mockRequest .getParameter ("exp" )).thenReturn (String .valueOf (Instant .now ().getEpochSecond () + 1000 ));
107107 when (mockRequest .getParameter ("sig" )).thenReturn ("invalidSignature" );
108108 when (mockRequest .getRequestURI ()).thenReturn ("/share/resource" );
109-
109+
110110 filter .doFilter (mockRequest , mockResponse , mockChain );
111-
111+
112112 verify (mockResponse ).sendError (HttpServletResponse .SC_FORBIDDEN , "Bad signature" );
113113 verifyNoInteractions (mockChain );
114114 }
115-
115+
116116 @ Test
117117 public void allowsRequestWhenSignatureIsValid () throws Exception {
118118 String secret = "secret" ;
119119 ShareSignedUrlFilter filter = new ShareSignedUrlFilter (true , secret );
120120 HttpServletRequest mockRequest = mock (HttpServletRequest .class );
121121 HttpServletResponse mockResponse = mock (HttpServletResponse .class );
122122 FilterChain mockChain = mock (FilterChain .class );
123-
123+
124124 String exp = String .valueOf (Instant .now ().getEpochSecond () + 1000 );
125125 String data = "/share/resource|" + exp ;
126126 String validSignature = HMACSignUtil .generateSignature (data , secret );
127-
127+
128128 when (mockRequest .getParameter ("exp" )).thenReturn (exp );
129129 when (mockRequest .getParameter ("sig" )).thenReturn (validSignature );
130130 when (mockRequest .getRequestURI ()).thenReturn ("/share/resource" );
131-
131+
132132 filter .doFilter (mockRequest , mockResponse , mockChain );
133-
133+
134134 verify (mockChain ).doFilter (mockRequest , mockResponse );
135135 }
136136}
0 commit comments