Skip to content

Commit c9bfec1

Browse files
committed
cleanup code
1 parent 097583f commit c9bfec1

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4021,17 +4021,6 @@ private void checkAndSetEnterSetupMode(VirtualMachineTO vmTo, Map<VirtualMachine
40214021
vmTo.setEnterHardwareSetup(enterSetup == null ? false : enterSetup);
40224022
}
40234023

4024-
protected VirtualMachineTO prepareVMTo(Long vmId) {
4025-
VMInstanceVO vm = _vmDao.findById(vmId);
4026-
VirtualMachineProfile vmProfile = new VirtualMachineProfileImpl(vm);
4027-
HypervisorGuru vmGuru = _hvGuruMgr.getGuru(vm.getHypervisorType());
4028-
VirtualMachineTO vmTO = vmGuru.implement(vmProfile);
4029-
updateVmMetadataManufacturerAndProduct(vmTO, vm);
4030-
setVmNetworkDetails(vm, vmTO);
4031-
return vmTO;
4032-
}
4033-
4034-
40354024
protected VirtualMachineTO getVmTO(Long vmId) {
40364025
final VMInstanceVO vm = _vmDao.findById(vmId);
40374026
final VirtualMachineProfile profile = new VirtualMachineProfileImpl(vm);

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@
105105
import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
106106
import org.apache.commons.lang3.builder.ToStringStyle;
107107
import org.apache.logging.log4j.LogManager;
108-
import org.apache.logging.log4j.ThreadContext;
109108
import org.apache.logging.log4j.Logger;
109+
import org.apache.logging.log4j.ThreadContext;
110110
import org.apache.xerces.impl.xpath.regex.Match;
111111
import org.joda.time.Duration;
112112
import org.libvirt.Connect;
@@ -170,7 +170,6 @@
170170
import com.cloud.host.Host.Type;
171171
import com.cloud.hypervisor.Hypervisor.HypervisorType;
172172
import com.cloud.hypervisor.kvm.dpdk.DpdkHelper;
173-
import com.cloud.hypervisor.kvm.resource.disconnecthook.DisconnectHook;
174173
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.ChannelDef;
175174
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.ClockDef;
176175
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.ConsoleDef;
@@ -199,6 +198,7 @@
199198
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.WatchDogDef;
200199
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.WatchDogDef.WatchDogAction;
201200
import com.cloud.hypervisor.kvm.resource.LibvirtVMDef.WatchDogDef.WatchDogModel;
201+
import com.cloud.hypervisor.kvm.resource.disconnecthook.DisconnectHook;
202202
import com.cloud.hypervisor.kvm.resource.rolling.maintenance.RollingMaintenanceAgentExecutor;
203203
import com.cloud.hypervisor.kvm.resource.rolling.maintenance.RollingMaintenanceExecutor;
204204
import com.cloud.hypervisor.kvm.resource.rolling.maintenance.RollingMaintenanceServiceExecutor;
@@ -240,7 +240,6 @@
240240
import com.cloud.vm.VirtualMachine;
241241
import com.cloud.vm.VirtualMachine.PowerState;
242242
import com.cloud.vm.VmDetailConstants;
243-
244243
import com.google.gson.Gson;
245244
import com.google.gson.JsonArray;
246245
import com.google.gson.JsonElement;
@@ -2205,14 +2204,6 @@ public String startVM(final Connect conn, final String vmName, final String doma
22052204
return null;
22062205
}
22072206

2208-
public void defineVMDomain(final Connect conn, final String domainXML) throws LibvirtException {
2209-
try {
2210-
conn.domainDefineXML(domainXML);
2211-
} catch (final LibvirtException ex) {
2212-
throw ex;
2213-
}
2214-
}
2215-
22162207
@Override
22172208
public boolean stop() {
22182209
try {

0 commit comments

Comments
 (0)