[KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24

Author: nvazquez

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

@@ -395,6 +395,7 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
     private final static long HYPERVISOR_LIBVIRT_VERSION_SUPPORTS_IO_URING = 6003000;
     private final static long HYPERVISOR_QEMU_VERSION_SUPPORTS_IO_URING = 5000000;
     private final static long HYPERVISOR_QEMU_VERSION_IDE_DISCARD_FIXED = 7000000;
+    private final static long HYPERVISOR_QEMU_VERSION_PC_MACHINE_TYPE_FIX = 8000000;
 
     protected HypervisorType hypervisorType;
     protected String hypervisorURI;
@@ -2903,6 +2904,31 @@ private boolean isGuestAarch64() {
         return AARCH64.equals(guestCpuArch);
     }
 
+    private boolean isQemuVersionConflictingSMBiosForWindowsGuestVMs() {
+        if (!isUbuntuOrDebianHost()) {
+            return false;
+        }
+        return getHypervisorQemuVersion() > HYPERVISOR_QEMU_VERSION_PC_MACHINE_TYPE_FIX;
+    }
+
+    /**
+     * Observed the QEMU version included on Ubuntu 24 conflicts retrieval of UUID for Windows VMs
+     * References:
+     * - <a href="https://gitlab.com/libvirt/libvirt/-/issues/807">Reported issue with CloudStack created Windows VMs on Ubuntu 24</a>
+     * - <a href="https://gitlab.com/qemu-project/qemu/-/issues/2008">Reported Issue on QEMU</a>
+     * Workaround: Set an older OS type machine on the XML domain: 'pc-i440fx-8.0'
+     */
+    private void setGuestMachineType(GuestDef guest) {
+        if (isGuestAarch64()) {
+            guest.setMachineType(VIRT);
+        } else if (isQemuVersionConflictingSMBiosForWindowsGuestVMs()) {
+            // Please check the method javadoc
+            guest.setMachineType("pc-i440fx-8.0");
+        } else {
+            guest.setMachineType(PC);
+        }
+    }
+
     /**
      * Creates a guest definition from a VM specification.
      */
@@ -2913,7 +2939,7 @@ protected GuestDef createGuestFromSpec(VirtualMachineTO vmTO, LibvirtVMDef vm, S
         guest.setManufacturer(vmTO.getMetadataManufacturer());
         guest.setProduct(vmTO.getMetadataProductName());
         guest.setGuestArch(guestCpuArch != null ? guestCpuArch : vmTO.getArch());
-        guest.setMachineType(isGuestAarch64() ? VIRT : PC);
+        setGuestMachineType(guest);
         guest.setBootType(GuestDef.BootType.BIOS);
         if (MapUtils.isNotEmpty(customParams)) {
             if (customParams.containsKey(GuestDef.BootType.UEFI.toString())) {