Do not rename the setting

Author: Pearl1594

engine/components-api/src/main/java/com/cloud/agent/AgentManager.java

@@ -39,8 +39,8 @@
 public interface AgentManager {
     static final ConfigKey<Integer> Wait = new ConfigKey<Integer>("Advanced", Integer.class, "wait", "1800", "Time in seconds to wait for control commands to return",
             true);
-    ConfigKey<Boolean> KVMAutoEnableDisable = new ConfigKey<>(Boolean.class,
-                    "kvm.host.auto.enable.disable",
+    ConfigKey<Boolean> EnableKVMAutoEnableDisable = new ConfigKey<>(Boolean.class,
+                    "enable.kvm.host.auto.enable.disable",
                     "Advanced",
                     "false",
                     "(KVM only) Enable Auto Disable/Enable KVM hosts in the cluster " +

engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java

@@ -1398,9 +1398,9 @@ private void processHostHealthCheckResult(Boolean hostHealthCheckResult, long ho
                 return;
             }
 
-            if (!BooleanUtils.toBoolean(KVMAutoEnableDisable.valueIn(host.getClusterId()))) {
+            if (!BooleanUtils.toBoolean(EnableKVMAutoEnableDisable.valueIn(host.getClusterId()))) {
                 logger.debug("{} is disabled for the cluster {}, cannot process the health check result " +
-                        "received for the host %s", KVMAutoEnableDisable.key(), host.getClusterId(), host.getName());
+                        "received for the host %s", EnableKVMAutoEnableDisable.key(), host.getClusterId(), host.getName());
                 return;
             }
 
@@ -1958,7 +1958,7 @@ public String getConfigComponentName() {
     @Override
     public ConfigKey<?>[] getConfigKeys() {
         return new ConfigKey<?>[] { CheckTxnBeforeSending, Workers, Port, Wait, AlertWait, DirectAgentLoadSize,
-                DirectAgentPoolSize, DirectAgentThreadCap, KVMAutoEnableDisable, ReadyCommandWait,
+                DirectAgentPoolSize, DirectAgentThreadCap, EnableKVMAutoEnableDisable, ReadyCommandWait,
                 GranularWaitTimeForCommands, RemoteAgentSslHandshakeTimeout, RemoteAgentMaxConcurrentNewConnections };
     }
 

engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql

@@ -42,8 +42,6 @@ CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.mshost_peer', 'fk_mshost_peer__
 -- Add last_id to the volumes table
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'last_id', 'bigint(20) unsigned DEFAULT NULL');
 
-UPDATE `cloud`.`configuration` set name = "kvm.host.auto.enable.disable" where name = "enable.kvm.host.auto.enable.disable";
-
 -- Add used_iops column to support IOPS data in storage stats
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.storage_pool', 'used_iops', 'bigint unsigned DEFAULT NULL COMMENT "IOPS currently in use for this storage pool" ');
 

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

@@ -1840,9 +1840,9 @@ private void handleAutoEnableDisableKVMHost(boolean autoEnableDisableKVMSetting,
                 _hostDetailsDao.update(hostDetail.getId(), hostDetail);
             } else if (!isUpdateFromHostHealthCheck && hostDetail != null &&
                     Boolean.parseBoolean(hostDetail.getValue()) && resourceEvent == ResourceState.Event.Disable) {
-                logger.info(String.format("The setting %s is enabled but the host %s is manually set into %s state," +
+                logger.info("The setting {} is enabled but the host {} is manually set into {} state," +
                                 "ignoring future auto enabling of the host based on health check results",
-                        AgentManager.KVMAutoEnableDisable.key(), host.getName(), resourceEvent));
+                        AgentManager.EnableKVMAutoEnableDisable.key(), host.getName(), resourceEvent);
                 hostDetail.setValue(Boolean.FALSE.toString());
                 _hostDetailsDao.update(hostDetail.getId(), hostDetail);
             } else if (hostDetail == null) {
@@ -1854,7 +1854,7 @@ private void handleAutoEnableDisableKVMHost(boolean autoEnableDisableKVMSetting,
     }
     private boolean updateHostAllocationState(HostVO host, String allocationState,
                                            boolean isUpdateFromHostHealthCheck) throws NoTransitionException {
-        boolean autoEnableDisableKVMSetting = AgentManager.KVMAutoEnableDisable.valueIn(host.getClusterId()) &&
+        boolean autoEnableDisableKVMSetting = AgentManager.EnableKVMAutoEnableDisable.valueIn(host.getClusterId()) &&
                 host.getHypervisorType() == HypervisorType.KVM;
         ResourceState.Event resourceEvent = getResourceEventFromAllocationStateString(allocationState);
         DetailVO hostDetail = _hostDetailsDao.findDetail(host.getId(), ApiConstants.AUTO_ENABLE_KVM_HOST);
@@ -1868,7 +1868,7 @@ private boolean updateHostAllocationState(HostVO host, String allocationState,
         if (isAutoEnableAttemptForADisabledHost(autoEnableDisableKVMSetting, isUpdateFromHostHealthCheck, hostDetail, resourceEvent)) {
             logger.debug(String.format("The setting '%s' is enabled and the health check succeeds on the host, " +
                             "but the host has been manually disabled previously, ignoring auto enabling",
-                    AgentManager.KVMAutoEnableDisable.key()));
+                    AgentManager.EnableKVMAutoEnableDisable.key()));
             return false;
         }
 
@@ -1982,7 +1982,7 @@ private void sendAlertAndAnnotationForAutoEnableDisableKVMHostFeature(HostVO hos
                                                                           boolean isUpdateFromHostHealthCheck,
                                                                           boolean isUpdateHostAllocation, String annotation) {
         boolean isAutoEnableDisableKVMSettingEnabled = host.getHypervisorType() == HypervisorType.KVM &&
-                AgentManager.KVMAutoEnableDisable.valueIn(host.getClusterId());
+                AgentManager.EnableKVMAutoEnableDisable.valueIn(host.getClusterId());
         if (!isAutoEnableDisableKVMSettingEnabled) {
             if (StringUtils.isNotBlank(annotation)) {
                 annotationService.addAnnotation(annotation, AnnotationService.EntityType.HOST, host.getUuid(), true);
@@ -2006,7 +2006,7 @@ private void sendAlertAndAnnotationForAutoEnableDisableKVMHostFeature(HostVO hos
                     host.getPodId(), msg, msg);
         } else {
             msg += String.format("is %s despite the setting '%s' is enabled for the cluster %s",
-                    isEventEnable ? "enabled" : "disabled", AgentManager.KVMAutoEnableDisable.key(),
+                    isEventEnable ? "enabled" : "disabled", AgentManager.EnableKVMAutoEnableDisable.key(),
                     host.getClusterId());
             if (StringUtils.isNotBlank(annotation)) {
                 msg += String.format(", reason: %s", annotation);

ui/src/views/infra/HostEnableDisable.vue

@@ -36,7 +36,7 @@
           class="form__item"
           name="reason"
           ref="reason"
-          :label="'The setting \'kvm.host.auto.enable.disable\' is enabled, ' +
+          :label="'The Auto Enable/Disable KVM Hosts functionality is enabled, ' +
             ' can specify a reason for ' + (resourcestate === 'Enabled' ? 'disabling' : 'enabling') + ' this host'">
           <a-textarea
             v-model:value="form.reason"