refactor error messages

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

@@ -968,8 +968,10 @@ public UserVm resetVMUserData(ResetVMUserDataCmd cmd) throws ResourceUnavailable
             throw new InvalidParameterValueException("Operation not supported on Shared FileSystem Instance");
         }
         if (Hypervisor.HypervisorType.External.equals(userVm.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Reset VM userdata not supported for {} as it is {} hypervisor instance",
+                    userVm, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    userVm.getName()));
         }
         _accountMgr.checkAccess(caller, null, true, userVm);
 
@@ -1019,8 +1021,10 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws ResourceUnavailableExce
             throw new InvalidParameterValueException("Operation not supported on Shared FileSystem Instance");
         }
         if (Hypervisor.HypervisorType.External.equals(userVm.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Reset VM SSH key not supported for {} as it is {} hypervisor instance",
+                    userVm, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    userVm.getName()));
         }
 
         VMTemplateVO template = _templateDao.findByIdIncludingRemoved(userVm.getTemplateId());
@@ -1954,8 +1958,10 @@ public UserVm upgradeVirtualMachine(ScaleVMCmd cmd) throws ResourceUnavailableEx
             throw new InvalidParameterValueException("Unable to find VM's UUID");
         }
         if (Hypervisor.HypervisorType.External.equals(vm.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Scale VM not supported for {} as it is {} hypervisor instance",
+                    vm, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    vm.getName()));
         }
         CallContext.current().setEventDetails("Vm Id: " + vm.getUuid());
 
@@ -8539,8 +8545,10 @@ public UserVm restoreVM(RestoreVMCmd cmd) throws InsufficientCapacityException,
             throw new InvalidParameterValueException("Operation not supported on Shared FileSystem Instance");
         }
         if (Hypervisor.HypervisorType.External.equals(vm.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Restore VM not supported for {} as it is {} hypervisor instance",
+                    vm, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    vm.getName()));
         }
         _accountMgr.checkAccess(caller, null, true, vm);
 

server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java

@@ -515,8 +515,10 @@ public VMSnapshot createVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiesce
             throw new InvalidParameterValueException("Operation not supported on Shared FileSystem Instance");
         }
         if (Hypervisor.HypervisorType.External.equals(userVm.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Create VM snapshot not supported for {} as it is {} hypervisor instance",
+                    userVm, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    userVm.getName()));
         }
         VMSnapshotVO vmSnapshot = _vmSnapshotDao.findById(vmSnapshotId);
         if (vmSnapshot == null) {

server/src/main/java/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java

@@ -436,8 +436,10 @@ public UserVm updateVMAffinityGroups(Long vmId, List<Long> affinityGroupIds) {
             throw new InvalidParameterValueException("Operation not supported on Shared FileSystem Instance");
         }
         if (Hypervisor.HypervisorType.External.equals(vmInstance.getHypervisorType())) {
-            throw new InvalidParameterValueException(String.format("Operation not supported for %s hypervisor Instance",
-                    Hypervisor.HypervisorType.External.name()));
+            logger.error("Update VM Affinity Group not supported for {} as it is {} hypervisor instance",
+                    vmInstance, Hypervisor.HypervisorType.External.name());
+            throw new InvalidParameterValueException(String.format("Operation not supported for instance: %s",
+                    vmInstance.getName()));
         }
 
         // Check that the VM is stopped

server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java

@@ -209,7 +209,8 @@ public ConsoleEndpoint generateConsoleEndpoint(Long vmId, String extraSecurityTo
             }
 
             if (Hypervisor.HypervisorType.External.equals(vm.getHypervisorType())) {
-                logger.info("Console access to this instance cannot be provided in case of hypervisor type External");
+                logger.error("Console access for {} cannot be provided it is {} hypervisor instance", vm,
+                        Hypervisor.HypervisorType.External);
                 return new ConsoleEndpoint(false, null, "Console access to this instance cannot be provided");
             }