change

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

@@ -195,6 +195,9 @@
 import com.google.gson.reflect.TypeToken;
 
 public class AutoScaleManagerImpl extends ManagerBase implements AutoScaleManager, AutoScaleService, Configurable {
+    // Windows OS has a limit of 15 characters for hostname
+    // https://learn.microsoft.com/en-us/troubleshoot/windows-server/active-directory/naming-conventions-for-computer-domain-site-ou
+    protected static final int MAX_WINDOWS_VM_HOSTNAME_LENGTH = 15;
 
     @Inject
     protected DispatchChainFactory dispatchChainFactory = null;
@@ -1962,7 +1965,9 @@ public void updateVmDetails(Map<String, String> deployParams, Map<String, String
 
     protected String getTrimmedHostNameForWindows(String name) {
         String valid = name.replaceAll("[^a-zA-Z0-9-]", "");
-        String hostName = valid.length() > 15 ? valid.substring(valid.length() - 15) : valid;
+        String hostName = valid.length() > MAX_WINDOWS_VM_HOSTNAME_LENGTH ?
+                valid.substring(valid.length() - MAX_WINDOWS_VM_HOSTNAME_LENGTH) :
+                valid;
         if (!hostName.isEmpty() && !Character.isLetter(hostName.charAt(0))) {
             for (int i = 0; i < hostName.length(); i++) {
                 if (Character.isLetter(hostName.charAt(i))) {
@@ -1971,7 +1976,7 @@ protected String getTrimmedHostNameForWindows(String name) {
                 }
             }
             if (!Character.isLetter(hostName.charAt(0))) {
-                hostName = hostName.length() < 15 ? "a" + hostName : "a" + hostName.substring(1);
+                hostName = "a" + hostName.substring(hostName.length() < MAX_WINDOWS_VM_HOSTNAME_LENGTH ? 0 : 1);
             }
         }
         return hostName;
@@ -1996,7 +2001,7 @@ protected Pair<String, String> getNextVmHostAndDisplayName(AutoScaleVmGroupVO as
         // Truncate vm group name because max length of vm name is 63
         int subStringLength = Math.min(asGroup.getName().length(), 63 - VM_HOSTNAME_PREFIX.length() - vmHostNameSuffix.length());
         String name = VM_HOSTNAME_PREFIX + asGroup.getName().substring(0, subStringLength) + vmHostNameSuffix;
-        if (!isWindows || name.length() <= 15) {
+        if (!isWindows || name.length() <= MAX_WINDOWS_VM_HOSTNAME_LENGTH) {
             return new Pair<>(name, name);
         }
         return new Pair<>(getTrimmedHostNameForWindows(name), name);

server/src/test/java/com/cloud/network/as/AutoScaleManagerImplTest.java

@@ -2595,10 +2595,14 @@ public void prefixesWithLetterIfNoLetterExists() {
     }
 
     @Test
-    public void trimsHostNameToLast15Characters() {
+    public void trimsHostNameToLastMaxCharacters() {
+        String name = "ThisIsAReallyLongHost-Name_1234";
         AutoScaleManagerImpl manager = new AutoScaleManagerImpl();
-        String result = manager.getTrimmedHostNameForWindows("ThisIsAReallyLongHost-Name_1234");
-        Assert.assertEquals("ngHost-Name1234", result);
+        String result = manager.getTrimmedHostNameForWindows(name);
+        String normalized = name.replace("_", "");
+        Assert.assertEquals(normalized
+                        .substring(normalized.length() - AutoScaleManagerImpl.MAX_WINDOWS_VM_HOSTNAME_LENGTH),
+                result);
     }
 
     @Test