refactor test mocks to use lenient behavior

Author: Daman Arora

plugins/integrations/kubernetes-service/src/test/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImplTest.java

@@ -651,7 +651,7 @@ public void testValidateNodeAffinityGroupsAntiAffinityNewNodeOnExistingHost() {
     public void testValidateNodeAffinityGroupsAntiAffinityNewNodeOnDifferentHost() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId = 100L;
         Long existingWorkerVmId = 200L;
@@ -660,7 +660,7 @@ public void testValidateNodeAffinityGroupsAntiAffinityNewNodeOnDifferentHost() {
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
         Mockito.when(affinityGroup.getType()).thenReturn("host anti-affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("anti-affinity-group");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("anti-affinity-group");
 
         VMInstanceVO newNode = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode.getHostId()).thenReturn(newNodeHostId);
@@ -688,15 +688,15 @@ public void testValidateNodeAffinityGroupsAntiAffinityNewNodeOnDifferentHost() {
     public void testValidateNodeAffinityGroupsAffinityNewNodeOnSameHost() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId = 100L;
         Long existingWorkerVmId = 200L;
         Long sharedHostId = 1000L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
         Mockito.when(affinityGroup.getType()).thenReturn("host affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("affinity-group");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("affinity-group");
 
         VMInstanceVO newNode = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode.getHostId()).thenReturn(sharedHostId);
@@ -775,12 +775,12 @@ public void testValidateNodeAffinityGroupsAntiAffinityMultipleNewNodesOnSameHost
         Long sharedHostId = 1000L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
-        Mockito.when(affinityGroup.getType()).thenReturn("host anti-affinity");
+        Mockito.lenient().when(affinityGroup.getType()).thenReturn("host anti-affinity");
         Mockito.when(affinityGroup.getName()).thenReturn("anti-affinity-group");
 
         VMInstanceVO newNode1 = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode1.getHostId()).thenReturn(sharedHostId);
-        Mockito.when(newNode1.getInstanceName()).thenReturn("new-node-vm-1");
+        Mockito.lenient().when(newNode1.getInstanceName()).thenReturn("new-node-vm-1");
 
         VMInstanceVO newNode2 = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode2.getHostId()).thenReturn(sharedHostId);
@@ -805,16 +805,16 @@ public void testValidateNodeAffinityGroupsAntiAffinityMultipleNewNodesOnSameHost
     public void testValidateNodeAffinityGroupsAntiAffinityMultipleNewNodesOnDifferentHosts() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId1 = 100L;
         Long newNodeId2 = 101L;
         Long hostId1 = 1000L;
         Long hostId2 = 1001L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
-        Mockito.when(affinityGroup.getType()).thenReturn("host anti-affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("anti-affinity-group");
+        Mockito.lenient().when(affinityGroup.getType()).thenReturn("host anti-affinity");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("anti-affinity-group");
 
         VMInstanceVO newNode1 = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode1.getHostId()).thenReturn(hostId1);
@@ -839,13 +839,13 @@ public void testValidateNodeAffinityGroupsAntiAffinityMultipleNewNodesOnDifferen
     public void testValidateNodeAffinityGroupsNodeWithNullHost() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId = 100L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
-        Mockito.when(affinityGroup.getType()).thenReturn("host anti-affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("anti-affinity-group");
+        Mockito.lenient().when(affinityGroup.getType()).thenReturn("host anti-affinity");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("anti-affinity-group");
 
         VMInstanceVO newNode = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode.getHostId()).thenReturn(null);
@@ -859,20 +859,20 @@ public void testValidateNodeAffinityGroupsNodeWithNullHost() {
 
         kubernetesClusterManager.validateNodeAffinityGroups(Arrays.asList(newNodeId), cluster);
 
-        Mockito.verify(vmInstanceDao).findById(newNodeId);
+        Mockito.verify(vmInstanceDao, Mockito.atLeastOnce()).findById(newNodeId);
     }
 
     @Test
     public void testValidateNodeAffinityGroupsNullNode() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId = 100L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
-        Mockito.when(affinityGroup.getType()).thenReturn("host anti-affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("anti-affinity-group");
+        Mockito.lenient().when(affinityGroup.getType()).thenReturn("host anti-affinity");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("anti-affinity-group");
 
         Mockito.when(kubernetesClusterAffinityGroupMapDao.listAffinityGroupIdsByClusterIdAndNodeType(1L, WORKER.name()))
             .thenReturn(Arrays.asList(10L));
@@ -883,21 +883,21 @@ public void testValidateNodeAffinityGroupsNullNode() {
 
         kubernetesClusterManager.validateNodeAffinityGroups(Arrays.asList(newNodeId), cluster);
 
-        Mockito.verify(vmInstanceDao).findById(newNodeId);
+        Mockito.verify(vmInstanceDao, Mockito.atLeastOnce()).findById(newNodeId);
     }
 
     @Test
     public void testValidateNodeAffinityGroupsAffinityNoExistingWorkers() {
         KubernetesCluster cluster = Mockito.mock(KubernetesCluster.class);
         Mockito.when(cluster.getId()).thenReturn(1L);
-        Mockito.when(cluster.getName()).thenReturn("test-cluster");
+        Mockito.lenient().when(cluster.getName()).thenReturn("test-cluster");
 
         Long newNodeId = 100L;
         Long newNodeHostId = 1000L;
 
         AffinityGroupVO affinityGroup = Mockito.mock(AffinityGroupVO.class);
-        Mockito.when(affinityGroup.getType()).thenReturn("host affinity");
-        Mockito.when(affinityGroup.getName()).thenReturn("affinity-group");
+        Mockito.lenient().when(affinityGroup.getType()).thenReturn("host affinity");
+        Mockito.lenient().when(affinityGroup.getName()).thenReturn("affinity-group");
 
         VMInstanceVO newNode = Mockito.mock(VMInstanceVO.class);
         Mockito.when(newNode.getHostId()).thenReturn(newNodeHostId);