fix for cluster arch change

Signed-off-by: Abhishek Kumar <[email protected]>

Author: shwstppr

engine/schema/src/main/java/com/cloud/host/dao/HostDao.java

@@ -197,5 +197,7 @@ List<Long> findHostIdsByZoneClusterResourceStateTypeAndHypervisorType(final Long
 
     List<Pair<HypervisorType, CPU.CPUArch>> listDistinctHypervisorArchTypes(final Long zoneId);
 
+    List<CPU.CPUArch> listDistinctArchTypes(final Long clusterId);
+
     List<HostVO> listByIds(final List<Long> ids);
 }

engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java

@@ -1775,6 +1775,21 @@ public List<Pair<HypervisorType, CPU.CPUArch>> listDistinctHypervisorArchTypes(f
                 .collect(Collectors.toList());
     }
 
+    @Override
+    public List<CPU.CPUArch> listDistinctArchTypes(final Long clusterId) {
+        GenericSearchBuilder<HostVO, CPU.CPUArch> sb = createSearchBuilder(CPU.CPUArch.class);
+        sb.and("clusterId", sb.entity().getClusterId(), SearchCriteria.Op.EQ);
+        sb.and("type", sb.entity().getType(), SearchCriteria.Op.EQ);
+        sb.select(null, Func.DISTINCT, sb.entity().getHypervisorType());
+        sb.done();
+        SearchCriteria<CPU.CPUArch> sc = sb.create();
+        if (clusterId != null) {
+            sc.setParameters("clusterId", clusterId);
+        }
+        sc.setParameters("type", Type.Routing);
+        return customSearch(sc, null);
+    }
+
     @Override
     public List<HostVO> listByIds(List<Long> ids) {
         if (CollectionUtils.isEmpty(ids)) {

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

@@ -1215,6 +1215,12 @@ public Cluster updateCluster(UpdateClusterCmd cmd) {
         }
 
         if (arch != null) {
+            List<CPU.CPUArch> archTypes = _hostDao.listDistinctArchTypes(cluster.getId());
+            if (archTypes.stream().anyMatch(a -> !a.equals(arch))) {
+                throw new InvalidParameterValueException(String.format(
+                        "Cluster has host(s) present with arch type(s): %s",
+                        StringUtils.join(archTypes.stream().map(CPU.CPUArch::getType).toArray())));
+            }
             cluster.setArch(arch.getType());
             doUpdate = true;
         }