Skip to content

Commit db8336e

Browse files
author
Daan Hoogland
committed
deal with warnings
1 parent 2d1f734 commit db8336e

File tree

2 files changed

+213
-320
lines changed

2 files changed

+213
-320
lines changed

engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java

Lines changed: 14 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -92,59 +92,38 @@ public interface ConfigurationManager {
9292

9393
/**
9494
* Updates a configuration entry with a new value
95-
<<<<<<< HEAD
96-
* @param userId
97-
* @param name
98-
* @param category
99-
* @param value
100-
* @param scope
101-
* @param id
102-
=======
103-
*
104-
>>>>>>> 674429f8ba7 (config cleanup)
10595
*/
10696
String updateConfiguration(long userId, String name, String category, String value, ConfigKey.Scope scope, Long id);
10797

10898
/**
10999
* Creates a new pod
110-
*
111-
<<<<<<< HEAD
112-
* @param userId
113-
* @param podName
114-
* @param zone
115-
* @param gateway
116-
* @param cidr
117-
* @param startIp
118-
* @param endIp
119-
* @param allocationState
120100
* @param skipGatewayOverlapCheck (true if it is ok to not validate that gateway IP address overlap with Start/End IP of the POD)
121-
* @param storageAccessGroups
122-
=======
123-
* @param skipGatewayOverlapCheck
124-
* (true if it is ok to not validate that gateway IP address overlap with Start/End IP of the POD)
125-
>>>>>>> 674429f8ba7 (config cleanup)
126101
* @return Pod
127102
*/
128103
HostPodVO createPod(long userId, String podName, DataCenter zone, String gateway, String cidr, String startIp, String endIp, String allocationState,
129104
boolean skipGatewayOverlapCheck, List<String> storageAccessGroups);
130105

131106
/**
132107
* Creates a new zone
133-
*
108+
* @param userId
109+
* @param zoneName
110+
* @param dns1
111+
* @param dns2
112+
* @param internalDns1
113+
* @param internalDns2
114+
* @param guestCidr
115+
* @param domain
116+
* @param domainId
117+
* @param zoneType
118+
* @param allocationState
134119
* @param networkDomain
135120
* @param isSecurityGroupEnabled
136-
<<<<<<< HEAD
121+
* @param isLocalStorageEnabled
137122
* @param ip6Dns1
138123
* @param ip6Dns2
124+
* @param isEdge
139125
* @param storageAccessGroups
140126
* @return
141-
* @throws
142-
* @throws
143-
=======
144-
* TODO
145-
* @param ip6Dns1 TODO
146-
* @param ip6Dns2 TODO
147-
>>>>>>> 2240215e42e (config cleanup)
148127
*/
149128
DataCenterVO createZone(long userId, String zoneName, String dns1, String dns2, String internalDns1, String internalDns2, String guestCidr, String domain,
150129
Long domainId, NetworkType zoneType, String allocationState, String networkDomain, boolean isSecurityGroupEnabled, boolean isLocalStorageEnabled, String ip6Dns1,
@@ -154,13 +133,7 @@ DataCenterVO createZone(long userId, String zoneName, String dns1, String dns2,
154133
* Deletes a VLAN from the database, along with all of its IP addresses. Will not delete VLANs that have allocated
155134
* IP addresses.
156135
*
157-
<<<<<<< HEAD
158-
* @param userId
159-
* @param vlanDbId
160-
* @param caller
161-
=======
162136
* @param caller TODO
163-
>>>>>>> 2240215e42e (config cleanup)
164137
* @return success/failure
165138
*/
166139
VlanVO deleteVlanAndPublicIpRange(long userId, long vlanDbId, Account caller);
@@ -202,7 +175,7 @@ DataCenterVO createZone(long userId, String zoneName, String dns1, String dns2,
202175
* @param internetProtocol
203176
* @param routingMode
204177
* @param specifyAsNumber
205-
* @return network offering object
178+
* @return the network offering
206179
*/
207180
NetworkOfferingVO createNetworkOffering(String name, String displayText, TrafficType trafficType, String tags, boolean specifyVlan, Availability availability,
208181
Integer networkRate, Map<Service, Set<Provider>> serviceProviderMap, boolean isDefault, Network.GuestType type, boolean systemOnly, Long serviceOfferingId,

0 commit comments

Comments
 (0)