Remove unnecessary parenthesis

winterhazel · winterhazel · commit dcc34465f217 · 2024-10-25T15:49:44.000-03:00
diff --git a/server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java b/server/src/main/java/com/cloud/network/firewall/FirewallManagerImpl.java
@@ -418,7 +418,7 @@ public void detectRulesConflict(FirewallRule newRule) throws NetworkRuleConflict
                 _firewallDao.loadDestinationCidrs(rule);
                 _firewallDao.loadDestinationCidrs((FirewallRuleVO) newRule);
 
-                duplicatedCidrs = (detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList()));
+                duplicatedCidrs = detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList());
             }
 
             boolean bothRulesPortForwarding = rule.getPurpose() == newRule.getPurpose() && rule.getPurpose() == Purpose.PortForwarding;

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,7 @@ public void detectRulesConflict(FirewallRule newRule) throws NetworkRuleConflict`
`418`	`418`	`_firewallDao.loadDestinationCidrs(rule);`
`419`	`419`	`_firewallDao.loadDestinationCidrs((FirewallRuleVO) newRule);`
`420`	`420`
`421`		`- duplicatedCidrs = (detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList()));`
	`421`	`+ duplicatedCidrs = detectConflictingCidrs(rule.getSourceCidrList(), newRule.getSourceCidrList()) && detectConflictingCidrs(rule.getDestinationCidrList(), newRule.getDestinationCidrList());`
`422`	`422`	`}`
`423`	`423`
`424`	`424`	`boolean bothRulesPortForwarding = rule.getPurpose() == newRule.getPurpose() && rule.getPurpose() == Purpose.PortForwarding;`