Update engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java

julien-vaz · bernardodemarco · web-flow · commit e239147126bc · 2025-03-04T10:58:45.000-03:00
Apply suggestion

Co-authored-by: Bernardo De Marco Gonçalves &lt;bernardomg2004@gmail.com&gt;
diff --git a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java b/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
@@ -237,7 +237,7 @@ List<StoragePool> reorderStoragePoolsBasedOnAlgorithm(List<StoragePool> pools, D
     void reorderRandomPools(List<StoragePool> pools) {
         StorageUtil.traceLogStoragePools(pools, logger, "pools to choose from: ");
         if (logger.isTraceEnabled()) {
-            logger.trace("Shuffle this so that we don't check the pools in the same order. Algorithm == '[{}]' (or no account?)", allocationAlgorithm);
+            logger.trace("Shuffling the list of storage pools, since the algorithm is '[{}]' or no account has been specified", allocationAlgorithm);
         }
         logger.debug("Pools to shuffle: [{}]", pools);
         Collections.shuffle(pools, secureRandom);

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ List<StoragePool> reorderStoragePoolsBasedOnAlgorithm(List<StoragePool> pools, D`
`237`	`237`	`void reorderRandomPools(List<StoragePool> pools) {`
`238`	`238`	`StorageUtil.traceLogStoragePools(pools, logger, "pools to choose from: ");`
`239`	`239`	`if (logger.isTraceEnabled()) {`
`240`		`- logger.trace("Shuffle this so that we don't check the pools in the same order. Algorithm == '[{}]' (or no account?)", allocationAlgorithm);`
	`240`	`+ logger.trace("Shuffling the list of storage pools, since the algorithm is '[{}]' or no account has been specified", allocationAlgorithm);`
`241`	`241`	`}`
`242`	`242`	`logger.debug("Pools to shuffle: [{}]", pools);`
`243`	`243`	`Collections.shuffle(pools, secureRandom);`