[routers] distiction between fatal failure and warning or unknown on healthchecks

Author: DaanHoogland

api/src/main/java/com/cloud/network/VirtualNetworkApplianceService.java

@@ -89,7 +89,6 @@ void startRouterForHA(VirtualMachine vm, Map<VirtualMachineProfile.Param, Object
     <T extends VirtualRouter> void collectNetworkStatistics(T router, Nic nic);
 
     enum RouterHealthStatus{
-        UNKNOWN, SUCCESS, WARNING, FAILURE;
+        SUCCESS, FAILURE, WARNING, UNKNOWN;
     }
-
 }

server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

@@ -1295,7 +1295,7 @@ private boolean restartGuestNetworkInDomainRouter(DomainRouterJoinVO router, Use
 
     /**
      * Attempts recreation of router by restarting with cleanup a VPC if any or a guest network associated in case no VPC.
-     * @param routerId - the id of the router to be recreated.
+     * @param router - the router to be recreated.
      * @return true if successfully restart is attempted else false.
      */
     private boolean recreateRouter(DomainRouterVO router) {
@@ -1572,7 +1572,7 @@ public Pair<Boolean, String> performRouterHealthChecks(long routerId) {
         List<String> failingChecks = getFailingChecks(router, answer);
         handleFailingChecks(router, failingChecks);
 
-        return new Pair<Boolean, String>(success, resultDetails);
+        return new Pair<>(success, resultDetails);
     }
 
     protected class UpdateRouterHealthChecksConfigTask extends ManagedContextRunnable {