show warning in create instance from backup form if guest os type is different

Author: abh1sar

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

@@ -388,7 +388,7 @@ public Map<String, String> getBackupDetailsFromVM(VirtualMachine vm) {
             details.put(ApiConstants.TEMPLATE_ID, template.getUuid());
             GuestOSVO guestOS = _guestOSDao.findById(guestOSId);
             if (guestOS != null) {
-                details.put(ApiConstants.OS_ID, guestOS.getUuid());
+                details.put(ApiConstants.OS_TYPE_ID, guestOS.getUuid());
             }
         }
 
@@ -2113,8 +2113,8 @@ Map<String, String> getDetailsFromBackupDetails(Long backupId) {
                 details.put(ApiConstants.IS_ISO, String.valueOf(template.getFormat().equals(Storage.ImageFormat.ISO)));
             }
         }
-        if (details.containsKey(ApiConstants.OS_ID)) {
-            GuestOSVO guestOS = _guestOSDao.findByUuid(details.get(ApiConstants.OS_ID));
+        if (details.containsKey(ApiConstants.OS_TYPE_ID)) {
+            GuestOSVO guestOS = _guestOSDao.findByUuid(details.get(ApiConstants.OS_TYPE_ID));
             if (guestOS != null) {
                 details.put(ApiConstants.OS_NAME, guestOS.getDisplayName());
             }

server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java

@@ -49,6 +49,7 @@
 import com.cloud.storage.VolumeApiService;
 import com.cloud.storage.VolumeVO;
 import com.cloud.storage.dao.DiskOfferingDao;
+import com.cloud.storage.dao.GuestOSDao;
 import com.cloud.storage.dao.VMTemplateDao;
 import com.cloud.storage.dao.VolumeDao;
 import com.cloud.user.Account;
@@ -234,6 +235,9 @@ public class BackupManagerTest {
     @Mock
     DomainDao domainDao;
 
+    @Mock
+    private GuestOSDao _guestOSDao;
+
     private Gson gson;
 
     private String[] hostPossibleValues = {"127.0.0.1", "hostname"};

ui/src/components/view/BackupMetadata.vue

@@ -91,7 +91,7 @@ export default {
       }
       const fieldOrder = [
         'templateid',
-        'osid',
+        'ostypeid',
         'hypervisor',
         'serviceofferingid',
         'nics',
@@ -112,9 +112,6 @@ export default {
       if (field === 'vmsettings') {
         return this.$t('label.settings')
       }
-      if (field === 'osid') {
-        return this.$t('label.ostypeid')
-      }
       return this.$t('label.' + String(field).toLowerCase())
     },
     getTemplateDisplayName () {

ui/src/components/view/DeployVMFromBackup.vue

@@ -164,6 +164,9 @@
                 :status="zoneSelected ? 'process' : 'wait'">
                 <template #description>
                   <div v-if="zoneSelected" style="margin-top: 15px">
+                    <div v-if="showTemplateOsIdWarning" style="color: red">
+                      {{ $t('message.create.instance.from.backup.template.osid.different') }}
+                    </div>
                     <a-card
                       :tabList="tabList"
                       :activeTabKey="tabKey"
@@ -933,6 +936,7 @@ export default {
       dataPreFill: {},
       showDetails: false,
       showRootDiskSizeChanger: false,
+      showTemplateOsIdWarning: false,
       showOverrideDiskOfferingOption: false,
       securitygroupids: [],
       rootDiskSizeFixed: 0,
@@ -975,6 +979,10 @@ export default {
     crossZoneInstanceCreationEnabled () {
       return this.dataPreFill.crosszoneinstancecreation
     },
+    showTemplateOsIdWarning2 () {
+      console.log('showTemplateOsIdWarning called with templateid:', this.form.templateid)
+      return this.form.templateid && this.templateOsIdIsDifferent(this.form.templateid)
+    },
     isNormalUserOrProject () {
       return ['User'].includes(this.$store.getters.userInfo.roletype) || store.getters.project.id
     },
@@ -1613,6 +1621,46 @@ export default {
         { id: 'storage_specific', description: 'storage_specific' }
       ]
     },
+    templateOsIdIsDifferent (templateid) {
+      console.log('templateOsIdIsDifferent called with templateid:', templateid)
+      console.log('dataPreFill:', this.dataPreFill)
+      if (!templateid) {
+        console.log('No templateid provided, returning false')
+        return false
+      }
+      if (!this.dataPreFill || !this.dataPreFill.osid) {
+        console.log('No dataPreFill.osid available, returning false')
+        return false
+      }
+      console.log('Looking for template with id:', templateid)
+      console.log('Available template options:', this.options.templates)
+      // Find the selected template by ID
+      let selectedTemplate = null
+      for (const key in this.options.templates) {
+        const templateList = _.get(this.options.templates[key], 'template', [])
+        console.log(`Searching in template category ${key}:`, templateList)
+        const template = _.find(templateList, (option) => option.id === templateid)
+        if (template) {
+          selectedTemplate = template
+          console.log('Found template:', selectedTemplate)
+          break
+        }
+      }
+      if (!selectedTemplate) {
+        console.log('Template not found with id:', templateid)
+        return false
+      }
+      if (!selectedTemplate.ostypeid) {
+        console.log('Selected template has no osid:', selectedTemplate)
+        return false
+      }
+      const isDifferent = selectedTemplate.ostypeid !== this.dataPreFill.osid
+      console.log('Template osid:', selectedTemplate.ostypeid)
+      console.log('DataPreFill osid:', this.dataPreFill.osid)
+      console.log('Are they different?', isDifferent)
+      // Return true if the template's osid is different from dataPreFill.osid
+      return isDifferent
+    },
     fetchInstaceGroups () {
       this.options.instanceGroups = []
       getAPI('listInstanceGroups', {
@@ -1658,6 +1706,13 @@ export default {
       if (name === 'templateid') {
         this.tabKey = 'templateid'
         this.form.templateid = value
+        if (this.templateOsIdIsDifferent(value)) {
+          console.log('Showing template osid warning')
+          this.showTemplateOsIdWarning = true
+        } else {
+          console.log('Hiding template osid warning')
+          this.showTemplateOsIdWarning = false
+        }
         this.form.isoid = null
         this.resetFromTemplateConfiguration()
         let template = ''

ui/src/views/storage/CreateVMFromBackup.vue

@@ -123,6 +123,8 @@ export default {
       this.dataPreFill.zoneid = this.resource.zoneid
       this.dataPreFill.crosszoneinstancecreation = this.backupOffering?.crosszoneinstancecreation || this.backupOffering.provider === 'dummy'
       this.dataPreFill.isIso = (this.vmdetails.isiso === 'true')
+      this.dataPreFill.ostypeid = this.resource.vmdetails.ostypeid
+      this.dataPreFill.osname = this.resource.vmdetails.osname
       this.dataPreFill.backupid = this.resource.id
       this.dataPreFill.computeofferingid = this.vmdetails.serviceofferingid
       this.dataPreFill.templateid = this.vmdetails.templateid