Skip to content

Commit f3e28fe

Browse files
Apply suggestions from code review
Co-authored-by: dahn <[email protected]>
1 parent c5b1e38 commit f3e28fe

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

server/src/main/java/com/cloud/bgp/BGPServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,9 @@ public boolean allocateASNumber(long zoneId, Long asNumber, Long networkId, Long
255255
netName = network.getName();
256256
}
257257

258-
String logMsg = Objects.nonNull(vpcId) ? ("VPC " + vpc) : ("network " + network);
258+
String networkName = Objects.nonNull(vpcId) ? ("VPC " + vpc) : ("network " + network);
259259
LOGGER.debug("Allocating the AS Number {} to {} on zone {}", asNumberVO::toString,
260-
logMsg::toString, () -> dataCenterDao.findById(zoneId));
260+
networkName::toString, () -> dataCenterDao.findById(zoneId));
261261
asNumberVO.setAllocated(true);
262262
asNumberVO.setAllocatedTime(new Date());
263263
if (Objects.nonNull(vpcId)) {

server/src/test/java/com/cloud/alert/AlertManagerImplTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ public void sendAlertTestWarnLogging() {
137137
Mockito.verify(alertManagerImplMock, Mockito.never()).sendMessage(any());
138138
}
139139

140-
141140
@Test
142141
public void testSendAlertWithNullParameters() throws MessagingException, UnsupportedEncodingException {
143142
// Given
@@ -162,7 +161,6 @@ public void testSendAlertWithNullParameters() throws MessagingException, Unsuppo
162161
assertEquals(alertType.getType(), capturedAlert.getType());
163162
}
164163

165-
166164
@Test(expected = NullPointerException.class)
167165
public void testSendAlertWithNullAlertType() throws MessagingException, UnsupportedEncodingException {
168166
// When

0 commit comments

Comments
 (0)