Update server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

DaanHoogland · sureshanaparti · web-flow · commit fa43e596fcd6 · 2025-07-22T19:04:23.000+02:00
Co-authored-by: Suresh Kumar Anaparti &lt;sureshkumar.anaparti@gmail.com&gt;
diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
@@ -1631,7 +1631,7 @@ private Pair<List<Long>, Integer> searchForUserVMIdsAndCount(ListVMsCmd cmd) {
                 userVmSearchCriteria.setParameters("hostId", hostId);
             }
 
-            if (storageId != null /* than pool != null as well */) {
+            if (storageId != null) {
                 if (pool.getPoolType().equals(Storage.StoragePoolType.DatastoreCluster)) {
                     List<StoragePoolVO> childDatastores = storagePoolDao.listChildStoragePoolsInDatastoreCluster(storageId);
                     userVmSearchCriteria.setJoinParameters("volume", "storagePoolId", childDatastores.stream().map(StoragePoolVO::getId).toArray());

Original file line number	Diff line number	Diff line change
`@@ -1631,7 +1631,7 @@ private Pair<List<Long>, Integer> searchForUserVMIdsAndCount(ListVMsCmd cmd) {`
`1631`	`1631`	`userVmSearchCriteria.setParameters("hostId", hostId);`
`1632`	`1632`	`}`
`1633`	`1633`
`1634`		`- if (storageId != null /* than pool != null as well */) {`
	`1634`	`+ if (storageId != null) {`
`1635`	`1635`	`if (pool.getPoolType().equals(Storage.StoragePoolType.DatastoreCluster)) {`
`1636`	`1636`	`List<StoragePoolVO> childDatastores = storagePoolDao.listChildStoragePoolsInDatastoreCluster(storageId);`
`1637`	`1637`	`userVmSearchCriteria.setJoinParameters("volume", "storagePoolId", childDatastores.stream().map(StoragePoolVO::getId).toArray());`