Error out create instance early for other providers

Author: abh1sar

api/src/main/java/org/apache/cloudstack/backup/BackupManager.java

@@ -234,6 +234,8 @@ public interface BackupManager extends BackupService, Configurable, PluggableSer
 
     Map<Long, Network.IpAddresses> getIpToNetworkMapFromBackup(Backup backup, boolean preserveIps, List<Long> networkIds);
 
+    Boolean canCreateInstanceFromBackup(Long backupId);
+
     /**
      * Restore a backup to a new Instance
      */

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

@@ -9414,11 +9414,12 @@ private void checkRootDiskSizeAgainstBackup(Long instanceVolumeSize,DiskOffering
 
     @Override
     public UserVm allocateVMFromBackup(CreateVMFromBackupCmd cmd) throws InsufficientCapacityException, ResourceAllocationException, ResourceUnavailableException {
-        Account owner = _accountService.getActiveAccountById(cmd.getEntityOwnerId());
-        Long zoneId = cmd.getZoneId();
-        DataCenter zone = _dcDao.findById(zoneId);
+        if (!backupManager.canCreateInstanceFromBackup(cmd.getBackupId())) {
+            throw new CloudRuntimeException("Create instance from backup is not supported for this provider.");
+        }
+        DataCenter zone = _dcDao.findById(cmd.getZoneId());
         if (zone == null) {
-            throw new InvalidParameterValueException("Unable to find zone by id=" + zoneId);
+            throw new InvalidParameterValueException("Unable to find zone by id=" + cmd.getZoneId());
         }
 
         BackupVO backup = backupDao.findById(cmd.getBackupId());
@@ -9527,6 +9528,7 @@ public UserVm allocateVMFromBackup(CreateVMFromBackupCmd cmd) throws Insufficien
         }
 
         List<Long> networkIds = cmd.getNetworkIds();
+        Account owner = _accountService.getActiveAccountById(cmd.getEntityOwnerId());
         LinkedHashMap<Integer, Long> userVmNetworkMap = getVmOvfNetworkMapping(zone, owner, template, cmd.getVmNetworkMap());
         if (MapUtils.isNotEmpty(userVmNetworkMap)) {
             networkIds = new ArrayList<>(userVmNetworkMap.values());

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

@@ -1153,6 +1153,17 @@ public Map<Long, Network.IpAddresses> getIpToNetworkMapFromBackup(Backup backup,
         return ipToNetworkMap;
     }
 
+    @Override
+    public Boolean canCreateInstanceFromBackup(final Long backupId) {
+        final BackupVO backup = backupDao.findById(backupId);
+        BackupOffering offering = backupOfferingDao.findByIdIncludingRemoved(backup.getBackupOfferingId());
+        if (offering == null) {
+            throw new CloudRuntimeException("Failed to find backup offering");
+        }
+        final BackupProvider backupProvider = getBackupProvider(offering.getProvider());
+        return backupProvider.supportsInstanceFromBackup();
+    }
+
     @Override
     public boolean restoreBackupToVM(final Long backupId, final Long vmId) throws ResourceUnavailableException {
         final BackupVO backup = backupDao.findById(backupId);