Unable to add services to ConfigDrive network service provider

[NuxRo]

problem

Following an upgrade from 4.19, on my current 4.20 I am unable to add extra services to this provider.
ConfigDrive in my installation only shows "userdata", as this was the only supportd one in 4.19, but I am unable to update it with the new supported services in 4.20, namely DHCP and DNS.

In the end I got there by hacking the DB, but this shouldn't be needed.

update physical_network_service_providers set dhcp_service_provided="1" where provider_name="ConfigDrive";
update physical_network_service_providers set dns_service_provided="1" where provider_name="ConfigDrive";

versions

ACS 4.20, KVM OL9

The steps to reproduce the bug

(localcloud) 🐱 > update networkserviceprovider id=bd56d109-6c65-44f4-a4bf-450551d0a694 servicelist=userdata,dhcp,dns
{
  "account": "admin",
  "accountid": "7bfaa643-760e-11ef-93a7-047d7b3ac777",
  "cmd": "org.apache.cloudstack.api.command.admin.network.UpdateNetworkServiceProviderCmd",
  "completed": "2025-01-29T11:52:23+0000",
  "created": "2025-01-29T11:52:23+0000",
  "domainid": "4ad6a7dd-760e-11ef-93a7-047d7b3ac777",
  "domainpath": "ROOT",
  "jobid": "8c33a043-14f6-4a12-ae5f-e11185ac73d1",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 431,
    "errortext": "Cannot update set of Services for this Service Provider 'ConfigDrive'"
  },
  "jobresultcode": 431,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "7bfbfeab-760e-11ef-93a7-047d7b3ac777"
}
🙈 Error: async API failed for job 8c33a043-14f6-4a12-ae5f-e11185ac73d1

What to do about it?

We should fix the API to allow modifying the service list in the providers.

[Pearl1594]

Fixed with #10372