Two API requests done towards api.github.com anytime someone visits ACS UI

[Sparc0]

problem

Anytime anyone visit our cloudstack webui you get two notifications in top right corner saying:

Forbidden
API rate limit exceeded for REDACTED_IP. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

It does not matter if you are logged in our not. It's because for some reason my browser do two API requests towards Github.

versions

ACS: 4.20.0

The steps to reproduce the bug

1. Visit the webui
2. Open browser console
3. F5
4. Two API requests towards Github is made to https://api.github.com/repos/apache/cloudstack/releases

What to do about it?

Can this behavior be disabled somehow?

[DaanHoogland]

@Sparc0 , I see only one call, but that IMNSHO is one too many. I will look into the functionality requiring this and into disabling this by default.

[DaanHoogland]

@Sparc0 the reason you might see two calls to api.github is because you have oauth enabled, is that true?

[Sparc0]

I dont use oauth.
This is a complete fresh and new mgmt server installed and i was met by the error on first login.

Since it does it towards https://api.github.com/repos/apache/cloudstack/releases does the UI check i run the latest version or something?

[DaanHoogland]

@Sparc0 , another question, you should only get this when you log on as "Root Admin". Are you saying you get it as any user?

Since it does it towards https://api.github.com/repos/apache/cloudstack/releases does the UI check i run the latest version or something?

Yes, it should tell you if there is a newer version.

[Sparc0]

We only have one user at the moment, have not setup LDAP or any other local users yet. I could try that next week see if that helps.

[DaanHoogland]

@Sparc0 , I created a PR that would reduce the double call to api.github, but I could not reproduce that part, so it is purely theoratical. Can you try #10533 ?

[Sparc0]

Sure, do you want me to clone your PR and build it using this instructions?
OR is the EL9 packages that blue mentions here available somewhere?

[DaanHoogland]

The packages are in a private lab to be used for integration tests. If you can build, please do. If all else fails we can arrange some file transfer.

[DaanHoogland]

@Sparc0 , did you manage to test?