managementserverid value inconsistency in shutdown APIs

[adietrich-ussignal]

problem

When using the shutdown APIs (prepareForShutdown, triggerShutdown, etc.) the management server ID is required, however, the return value appears to be the database ID.

prepare forshutdown managementserverid=0b2faa01-706f-4f37-82ff-3e5e8f0971f8
{
  "prepareforshutdown": {
    "managementserverid": 1,
    "pendingjobscount": 0,
    "readyforshutdown": true,
    "shutdowntriggered": true
  }
}

versions

ACS 4.19.2.0
CMK 6.4.0

The steps to reproduce the bug

1. prepare forshutdown managementserverid=<UUID of management server>
2. Observe return values.
   ...

What to do about it?

To align with other API calls, it would be more valuable to pass the UUID of the management server in the return value for managementserverid.

[sureshanaparti]

@adietrich-ussignal these responses are updated (with UUID of the management server) in some shutdown improvements here: #9854 (will be included in 4.21 release).

[DaanHoogland]

@adietrich-ussignal , does @sureshanaparti 's remark answer your concerns ? i.e. can we close this issue?

[adietrich-ussignal]

It seems odd this was tagged as a feature when its inconsistent with many of the other API operations in the platform. Based on my understanding of the PR, it looks like the msid is being set to the UUID and not the database ID.

[DaanHoogland]

It seems odd this was tagged as a feature when its inconsistent with many of the other API operations in the platform. Based on my understanding of the PR, it looks like the msid is being set to the UUID and not the database ID.

@adietrich-ussignal , it is actually an improvement, but it seems github doesn't know this type of issue. We could as well have tagged it as a "task". In the past a lot of API would return DB ID as id and a separate field uuid. historic "feature" or artifact if you will. It may feel as a bug to you , I appreciate that, but it was actually implemented on purpose.

[rohityadavcloud]

Raised a PR to fix the use of internal DB ID in the response - #10717