Api/UI/Polish/Improvement: Wrong api is called when admin tries to disable a service offering or a disk offering

[kiranchavala]

problem

Currenlty if a Admin users selects the disable option for service offering and disk offering , the offering is removed from the UI

The delete offering API is called instead of update offering

versions

Acs 4.20.1

The steps to reproduce the bug

1. On existing service offering select the disable offering button

2. The delete service offering API call is called and the service offering is removed from API

https://cloudstack.apache.org/api/apidocs-4.20/apis/deleteServiceOffering.html

3. Similar for disk offering

...

What to do about it?

CloudStack should follow the behaviour of network offering and vpc offering and should change the state to enable/disable to maintain consistency

https://cloudstack.apache.org/api/apidocs-4.20/apis/updateNetworkOffering.html

https://cloudstack.apache.org/api/apidocs-4.20/apis/updateVPCOffering.html

https://cloudstack.apache.org/api/apidocs-4.20/apis/deleteNetworkOffering.html

https://cloudstack.apache.org/api/apidocs-4.20/apis/deleteVPCOffering.html

[harikrishna-patnala]

@kiranchavala Both the APIs deleteServiceOffering and updateServiceOffering with state value "Inactive" does the same job of setting state to Inactive state. This is by design from the beginning.

Please check if you are fine with this

[kiranchavala]

@harikrishna-patnala

Ideally, the CloudStack UI should call the deleteServiceOffering API for the compute service offerings when the user tries to delete

If you compare with network offerings and vpc offerings, CloudStack provides the option to disable and also delete them from the UI , Also the state of the offering is set to Enable or disable

Currently, for compute, system offerings even though it using "update service offeringAPI" it won't set the removed date in the db for which a fix Is present

#11508
#11544

Please consider this as a polish issue, in order to maintain consistency across all offerings ( compute, system, disk , network , vpc) offerings

[harikrishna-patnala]

@kiranchavala I doubt if that fix is really needed, as historically we are using the state column whether to use that offering or not. We can discuss further on the issue or PR #11508 #11544

We can anyways fix the current issue as both APIs are same. I'll quickly create one.