Missing Guest Network DNS server in VPC network after upgrade 4.21.0

[levindecaro]

problem

Before the upgrade to version 4.21.0, the DHCP server for VPC Guest Network tier included both the Guest Network Gateway and the DNS server defined in the zone as nameservers. However, after upgrading from version 4.20.1 to 4.21.0, the DHCP server only announces the DNS server defined in the zone. Consequently, all internal DNS resolutions fail due to this change.

in 4.20.1 VPC VR

/etc/dnsmasq.d/cloud.conf

dhcp-option=tag:interface-eth0-0,6,10.2.1.1,172.17.2.1

in 4.21.0 VPC VR

/etc/dnsmasq.d/cloud.conf

dhcp-option=tag:interface-eth0-0,6,172.17.2.1

versions

ACS: 4.21.0
OS: OL9 x86_64
hypervisors: KVM
storage: NFS(SharedMountPoint)
network: vxlan

The steps to reproduce the bug

1. Create a VPC with "Default VPC offering"
2. Create a guest network with "DefaultIsolatedNetworkOfferingForVpcNetworks" under that VPC
3. launch a VM
4. verify /etc/resolv.conf are missing guest network gateway ip as nameserver

What to do about it?

No response

[kiranchavala]

Thanks @levindecaro

Able to reproduce the issue

0n 4.20.1

On 4.21

[weizhouapache]

thanks @kiranchavala
can you test with regular isolated network ?

[weizhouapache]

it seems to be caused by #9102

cloudstack/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py

Lines 114 to 117 in 3d6ec29

	if gateway in dns_list:
	dns_list.remove(gateway)
	if gn.data['router_guest_ip'] != ip:
	dns_list.insert(0, ip)

the gateway has been removed from DNS list , but the guest IP (same as gateway in VPC) is not added back.
cc @Pearl1594 @nvazquez

[levindecaro]

thanks @kiranchavala can you test with regular isolated network ?

regular isolated network is working fine for me.

[weizhouapache]

@levindecaro
can you make the change below manually in a VR and retry (start a new vm or stop/start an existing vm) ?

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
index e74e801f59d..0f9f4a59374 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
@@ -110,7 +110,7 @@ class CsDhcp(CsDataBag):
             if gn.get_dns() and device:
                 sline = "dhcp-option=tag:interface-%s-%s,6" % (device, idx)
                 dns_list = [x for x in gn.get_dns() if x]
-                if (self.config.is_vpc() or self.config.is_router()) and ('is_vr_guest_gateway' in gn.data and gn.data['is_vr_guest_gateway']):
+                if (self.config.is_vpc() or self.config.is_router()) and ('is_vr_guest_gateway' in gn.data and not gn.data['is_vr_guest_gateway']):
                   if gateway in dns_list:
                     dns_list.remove(gateway)
                   if gn.data['router_guest_ip'] != ip:

[levindecaro]

@weizhouapache

It works perfectly, thank you!

[nvazquez]

Thanks @levindecaro @kiranchavala @weizhouapache, we'll work on the fix