Incorrect disk offering is listed when volume migration is initiated

[kiranchavala]

ISSUE TYPE

Bug

COMPONENT NAME

Component: Bug

CLOUDSTACK VERSION

Cloudstack version 4.19.1

SUMMARY

Incorrect disk offering is listed when volume migration is initiated

Steps to reproduce the behaviour

1. Create a 3 primary storages (Pri-storage1 with no tags , Pri-storage2 with tag x2, Pri-storage3 with no tags)

2. Create a disk offering let's with a different with tag x1.

3. Launch a vm on Pri-storage1

4. Stop the vm

5. Try to Migrate the vm's volume to Pri-storage2 ( Only the small disk offering UUID is shown)

6. Try to Migrate the vm's volume to Pri-storage3 (all the disk offerings are shown)

Expected behaviour

Since there are no disk offerings associated with tag x2, Cloudstack should not display any disk offerings

Actual Behaviour

The small disk offering uuid is show

Currently, cloudstack is calling the list disk offerings based on the storage id

http:///client/api/?storageid=84571068-e616-3f1a-940b-cd4a7b01a3a1&listall=true&command=listDiskOfferings&response=json&sessionkey=-wChbvJAKBJz2u68r18S0yLIMoA

[DaanHoogland]

@kiranchavala I've been a bit strugling with this, but I think the implementation is the reverse from what you are stating. The limitation is coming from the offering and not from the storage;
an offering with 'x1' has to go on a storage with 'x1', but an offering with no tag may well go on a storage with 'x1' as well. So a storage with 'x1', 'y2' and 'z3' may host disks with any offering that has any combination of those tags.
Am I missing something?

[kiranchavala]

@DaanHoogland

On a second thought after going through the issue again I found no issue

Will be closing this issue

verified the following scenario and its working fine

End user performs the following

1. Tries to migrate a volume (which is created from disk offering which has a storage tag )
2. Selects a particular primary storage. ( Currently there is the same tag on primary storages)
3. Selects replace the disk offering of the volume.

Cloudstack should list only the disk offerings which has the matching tag in the UI (for replace disk offering action)

Currently its working fine