Skip to content

Bug fix : add check befor fencing #10039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leo79901 wants to merge 10 commits into from
Closed

Bug fix : add check befor fencing #10039

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d382636
add check befor fencing
leo79901 Dec 4, 2024
3977686
Merge pull request #1 from leo79901/leo79901-patch-1
leo79901 Dec 4, 2024
a6a23f7
Merge branch 'apache:main' into main
leo79901 Dec 4, 2024
3911514
Update KVMHAProvider.java
leo79901 Dec 4, 2024
93818f6
Update KVMHAProvider.java
leo79901 Dec 4, 2024
b239b6e
Update KVMHAProvider.java
leo79901 Dec 4, 2024
79472dc
Update KVMHAProvider.java
leo79901 Dec 4, 2024
3e8c57d
Update KVMHAProvider.java
leo79901 Dec 4, 2024
3a69040
Update KVMHAProvider.java
leo79901 Dec 5, 2024
67e33f6
Update plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kv…
leo79901 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kvm/ha/KVMHAProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.cloudstack.outofbandmanagement.OutOfBandManagement.PowerOperation;
import org.apache.cloudstack.outofbandmanagement.OutOfBandManagementService;
import org.joda.time.DateTime;
import com.cloud.host.Status;

import javax.inject.Inject;

Expand Down Expand Up @@ -84,11 +85,18 @@ public boolean recover(Host r) throws HARecoveryException {

@Override
public boolean fence(Host r) throws HAFenceException {

try {
if (outOfBandManagementService.isOutOfBandManagementEnabled(r)){
final OutOfBandManagementResponse resp = outOfBandManagementService.executePowerOperation(r, PowerOperation.OFF, null);
return resp.getSuccess();
// host exists and is managed OOB
if (r != null && outOfBandManagementService.isOutOfBandManagementEnabled(r)) {
// check host status
if (Status.Down.equals(r.getStatus())) {
logger.info("Host " + r.getName() + " is already down. Returning success.");
return true;
} else {
final OutOfBandManagementResponse resp = outOfBandManagementService.executePowerOperation(r, PowerOperation.OFF, null);
return resp.getSuccess();
}
} else {
logger.warn("OOBM fence operation failed for this host " + r.getName());
return false;
Expand Down
Loading